feat: archive/unarchive workflow's execution #271
Conversation
anrusina
requested review from
a team,
Pianist038801,
jsonporter and
govalt
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #271 +/- ##
=========================================
Coverage ? 65.18%
=========================================
Files ? 377
Lines ? 8359
Branches ? 1500
=========================================
Hits ? 5449
Misses ? 2910
Partials ? 0 Continue to review full report at Codecov.
|
| @@ -0,0 +1,8 @@ | |||
| export const createLocalizedString = (strings = {}) => (key, ...rest) => { | |||
There was a problem hiding this comment.
Is this something we want to establish as a pattern? Currently we don't have plans for localized strings?
There was a problem hiding this comment.
This pattern will not require you to localize strings, but will keep all strings in file sections, which make them easier to change, and makes easier to switch to localization if we would have such plan in future.
Most problems with localizations are usually come from struggle to find all strings and get developer used to t("string") notation.
Proper localization will require files to be located in folders per language - but we won't go there until we will start to really discuss localization.
Signed-off-by: Nastya Rusina <[email protected]>
Signed-off-by: Nastya Rusina <[email protected]>
Signed-off-by: Nastya Rusina <[email protected]>
anrusina
force-pushed
the
narusina/archive
branch
from
e528114 to
9fe5bdb
Compare
| flexBasis: workflowExecutionsTableColumnWidths.actions, | ||
| marginLeft: theme.spacing(2), | ||
| marginRight: theme.spacing(2), | ||
| textAlign: 'left' | ||
| textAlign: 'right' |
There was a problem hiding this comment.
As per our conversation, put actions to right side + updated column nanme size
# [0.41.0](http://github.com/lyft/flyteconsole/compare/v0.40.0...v0.41.0) (2022-02-03) ### Features * archive/unarchive workflow's execution ([#271](http://github.com/lyft/flyteconsole/issues/271)) ([2c6c041](http://github.com/lyft/flyteconsole/commit/2c6c04147bf27219e5bcaf77642250ed8385b564))
|
🎉 This PR is included in version 0.41.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Signed-off-by: Nastya Rusina [email protected]
New feature: Archive/Unarchive workflow's executions
Video walk through on archive feature: https://share.getcloudapp.com/4guZZp6R
Video on storybook changes: https://share.getcloudapp.com/2NuvvZn9
Type
Are all requirements met?
Complete description
Updated flyteidl to latest version
Added ExecutionState enum and calls to UpdateExecutionState
Added notistack to support error and success notifications
Ensured that items could be archived and unarchived from "workflow->execution" and "all executions" view.
Added new styling for archived items
Updates storybook to observe all recent changes
Added "localization" string support, which is a bit closer to localization standards
Tracking Issue
adds feature for flyteorg/flyte#2046