Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add workflow versions table #193

Merged
merged 1 commit into from
Aug 31, 2021
Merged

feat: add workflow versions table #193

merged 1 commit into from
Aug 31, 2021

Conversation

govalt
Copy link
Contributor

@govalt govalt commented Aug 31, 2021

Signed-off-by: csirius [email protected]

TL;DR

Added Workflow versions table to show executions based on workflow version.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Tracking Issue

implements flyteorg/flyte#1386

Follow-up issue

NA

@codecov
Copy link

codecov bot commented Aug 31, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@14304c7). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #193   +/-   ##
=========================================
  Coverage          ?   65.99%           
=========================================
  Files             ?      354           
  Lines             ?     7384           
  Branches          ?     1244           
=========================================
  Hits              ?     4873           
  Misses            ?     2511           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14304c7...adf690a. Read the comment docs.

Copy link
Contributor

@Pianist038801 Pianist038801 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 0.25.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

jsonporter added a commit that referenced this pull request Sep 17, 2021
* feat: add workflow versions table

Signed-off-by: csirius <[email protected]>
Signed-off-by: Jason Porter <[email protected]>

* chore(release): Release 0.25.0 [skip ci]

# [0.25.0](http://github.com/lyft/flyteconsole/compare/v0.24.0...v0.25.0) (2021-08-31)

### Features

* add workflow versions table ([#193](http://github.com/lyft/flyteconsole/issues/193)) ([6fff87e](http://github.com/lyft/flyteconsole/commit/6fff87e40007fd15faae634eb6402045c067dd2c))

Signed-off-by: Jason Porter <[email protected]>

* improvement: show proper error message for aborted workflows (#195)

* improvement: show proper error message for aborted workflows

Signed-off-by: Pianist038801 <[email protected]>

* improvement: show abort message in the execution list

Signed-off-by: Pianist038801 <[email protected]>

Co-authored-by: Pianist038801 <[email protected]>
Signed-off-by: Jason Porter <[email protected]>

* Fix/versions executions gap (#197)

* feat: add workflow versions table

Signed-off-by: csirius <[email protected]>

* fix: space between versions and executions table

Signed-off-by: csirius <[email protected]>
Signed-off-by: Jason Porter <[email protected]>

* feat: workflow version details page

Signed-off-by: csirius <[email protected]>
Signed-off-by: Jason Porter <[email protected]>

* Pre merge checkin

Signed-off-by: Jason Porter <[email protected]>

* fix: this is rfc, do not deploy until resolved; details in comments (#172)

* fix: this is rfc, do not deploy until resolved; details in comments

Signed-off-by: Jason Porter <[email protected]>

* fix: this is rfc, do not deploy until resolved; details in comments

note: deploying with caution; the believe if that it was incorrect to use
meta.

Signed-off-by: Jason Porter <[email protected]>

* fix: show field types on json launch form (#199)

Signed-off-by: Pianist038801 <[email protected]>

Co-authored-by: Pianist038801 <[email protected]>
Signed-off-by: Jason Porter <[email protected]>

* chore(release): Release 0.25.1 [skip ci]

## [0.25.1](http://github.com/lyft/flyteconsole/compare/v0.25.0...v0.25.1) (2021-09-13)

### Bug Fixes

* show field types on json launch form ([#199](http://github.com/lyft/flyteconsole/issues/199)) ([a42b9f8](http://github.com/lyft/flyteconsole/commit/a42b9f8520fcd24dee752111e606ad9ae9bd88f5))
* this is rfc, do not deploy until resolved; details in comments ([#172](http://github.com/lyft/flyteconsole/issues/172)) ([67dd183](http://github.com/lyft/flyteconsole/commit/67dd18397caf40e350da40e0672e500eaa9f338a))

Signed-off-by: Jason Porter <[email protected]>

* Minor fixes

Signed-off-by: Jason Porter <[email protected]>

* Feat/version details (#198)

* feat: add workflow versions table

Signed-off-by: csirius <[email protected]>

* feat: workflow version details page

Signed-off-by: csirius <[email protected]>
Signed-off-by: Jason Porter <[email protected]>

* fix: repopulate struct input fields on relaunch form (#201)

Signed-off-by: Pianist038801 <[email protected]>

Co-authored-by: Pianist038801 <[email protected]>
Signed-off-by: Jason Porter <[email protected]>

* Graph ux feature add legend (#196)

* Checkin and merge to master

Signed-off-by: Jason Porter <[email protected]>

* fixed one more

Signed-off-by: Jason Porter <[email protected]>

* chore(release): Release 0.25.2 [skip ci]

## [0.25.2](http://github.com/lyft/flyteconsole/compare/v0.25.1...v0.25.2) (2021-09-16)

### Bug Fixes

* repopulate struct input fields on relaunch form ([#201](http://github.com/lyft/flyteconsole/issues/201)) ([950e080](http://github.com/lyft/flyteconsole/commit/950e080a2c52c6294630f0ffd1410b0e45b50a8d))

Signed-off-by: Jason Porter <[email protected]>

* final before pr

Signed-off-by: Jason Porter <[email protected]>

* Fixed issues created by bad rebase

Signed-off-by: Jason Porter <[email protected]>

* Fixed more merge issues

Signed-off-by: Jason Porter <[email protected]>

Co-authored-by: csirius <[email protected]>
Co-authored-by: flyte bot <[email protected]>
Co-authored-by: pianist <[email protected]>
Co-authored-by: Pianist038801 <[email protected]>
Co-authored-by: csirius <[email protected]>
@anrusina anrusina deleted the 1386-versions-table branch January 13, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI / UX Issues relating to ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants