Skip to content

Commit

Permalink
fix: this is rfc, do not deploy until resolved; details in comments (#…
Browse files Browse the repository at this point in the history
…172)

* fix: this is rfc, do not deploy until resolved; details in comments

Signed-off-by: Jason Porter <[email protected]>

* fix: this is rfc, do not deploy until resolved; details in comments

note: deploying with caution; the believe if that it was incorrect to use
meta.

Signed-off-by: Jason Porter <[email protected]>
  • Loading branch information
jsonporter authored Sep 13, 2021
1 parent ff0df39 commit 67dd183
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/components/Executions/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,9 @@ export const taskExecutionIsTerminal = (taskExecution: TaskExecution) =>
taskExecution.closure &&
terminalTaskExecutionStates.includes(taskExecution.closure.phase);

/** Returns a NodeId from a given NodeExecution */
export function getNodeExecutionSpecId(nodeExecution: NodeExecution): string {
return nodeExecution.metadata?.specNodeId || nodeExecution.id.nodeId;
return nodeExecution.id.nodeId;
}

interface GetExecutionDurationMSArgs {
Expand Down

0 comments on commit 67dd183

Please sign in to comment.