Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Replace kind with sandbox in integration test #308

Closed
wants to merge 24 commits into from
Closed

Conversation

yindia
Copy link
Contributor

@yindia yindia commented Dec 18, 2021

TL;DR

  • Replace kind with flytectl sandbox for integration
  • It's will help in running it on local

Local Testing

$ flytectl sandbox start --source .
$ flytectl sandbox exec -- docker build -t flyteorg/flyteadmin:builder --target builder .
$ flytectl sandbox exec -- helm upgrade flyte -n flyte --kubeconfig=/etc/rancher/k3s/k3s.yaml flyteorg/flyte -f /flyteorg/share/flyte/values.yaml -f /root/script/integration/k8s/values.yaml --set flyteadmin.image.repository=flyteorg/flyteadmin,flyteadmin.image.tag=builder
$ make k8s_integration_execute

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes flyteorg/flyte#518

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

@codecov
Copy link

codecov bot commented Dec 18, 2021

Codecov Report

Merging #308 (95dbb7c) into master (c1b8fa4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #308   +/-   ##
=======================================
  Coverage   58.50%   58.50%           
=======================================
  Files         152      152           
  Lines       11018    11018           
=======================================
  Hits         6446     6446           
  Misses       3873     3873           
  Partials      699      699           
Flag Coverage Δ
unittests 57.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1b8fa4...95dbb7c. Read the comment docs.

@pmahindrakar-oss
Copy link
Contributor

For DEV mode where we want to run individual tests here are the steps i follow
1] Run the sandbox using helm install
helm install -n flyte -f values.yaml --create-namespace flyte .
2] Port forward minio and db
3] Run admin using dlv which helps debug the admin code while integration tests run

dlv --listen=:2345 --headless=true --api-version=2 --accept-multiclient exec ${GOPATH}/bin/flyteadmin serve -- --config  flyteadmin_config.yaml --server.kube-config ~/.kube/config

4] Connect to admin debug port from IDE
5] create project with name project, adminproject, flytekitproject (This happens in integration.yaml but needs to be setup separately in case of local)
6] Run individual integration test from IDE in debug mode

This gives tighter control for me to run individual integration tests than running the entire suite. But what you have added is also required.

Signed-off-by: Yuvraj <[email protected]>
@yindia yindia marked this pull request as draft January 24, 2022 08:45
@yindia yindia closed this Feb 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Improve ease of locally running flyteadmin integration tests
2 participants