Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Improve ease of locally running flyteadmin integration tests #518

Open
1 of 20 tasks
katrogan opened this issue Sep 23, 2020 · 9 comments
Open
1 of 20 tasks

[BUG] Improve ease of locally running flyteadmin integration tests #518

katrogan opened this issue Sep 23, 2020 · 9 comments
Assignees
@yindia
Labels
flyteadmin Issue for FlyteAdmin Service housekeeping Issues that help maintain flyte and keep it tech-debt free stale

Comments

@katrogan
Copy link
Contributor

Describe the bug
In short the current system for running integration tests locally on a user's machine lacks polish. It requires manual config tweaking, port-forwarding, etc. This should be investigated to see if it can be improved.

Expected behavior
A clear and concise description of what you expected to happen.

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

To Reproduce
Steps to reproduce the behavior:

  1. ...
  2. ...

Screenshots
If applicable, add screenshots to help explain your problem.

Environment
Flyte component

  • Sandbox (local or on one machine)
  • Cloud hosted
    • AWS
    • GCP
    • Azure
  • Baremetal
  • Other

Additional context
Add any other context about the problem here.
@katrogan katrogan added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Sep 23, 2020
@katrogan katrogan self-assigned this Sep 23, 2020
@katrogan katrogan removed the untriaged This issues has not yet been looked at by the Maintainers label Sep 23, 2020
@EngHabu EngHabu added this to the 0.18.0 milestone Aug 31, 2021
@pingsutw pingsutw self-assigned this Sep 13, 2021
@yindia yindia assigned yindia and unassigned pingsutw Sep 16, 2021
@yindia
Copy link
Contributor

yindia commented Sep 23, 2021

It will be cover with issue #1474

@katrogan
Copy link
Contributor Author

@evalsocket so actually admin integration tests are a different target than endtoend tests. This issue is to address the fact that config changes eg getDbConfig() vs getLocalDbConfig() must be called based on the environment the tests are run in

@EngHabu EngHabu removed this from the 0.18.0 milestone Oct 6, 2021
@EngHabu
Copy link
Contributor

EngHabu commented Oct 6, 2021

Triage: Looks like nobody is working on this for the foreseeable future. Will revisit in the next bugSquash sprint.

@yindia
Copy link
Contributor

yindia commented Nov 17, 2021 •
edited
Loading

@EngHabu i did some work in issue #1474.

@yindia yindia mentioned this issue Dec 20, 2021
Closed
8 tasks
@kumare3
Copy link
Contributor

kumare3 commented Feb 1, 2022

I do not think this is a bug, this is a housekeeping issue. Relabeling

@kumare3 kumare3 added housekeeping Issues that help maintain flyte and keep it tech-debt free flyteadmin Issue for FlyteAdmin Service and removed bug Something isn't working labels Feb 1, 2022
@yindia
Copy link
Contributor

yindia commented Feb 1, 2022

yes

eapolinario pushed a commit to eapolinario/flyte that referenced this issue Jul 24, 2023
@hamersaw
Bumping go version to 1.19 (flyteorg#518)
a89b359 
* bumping go version to 1.19

Signed-off-by: Daniel Rammer <[email protected]>

* fixed go generatea

Signed-off-by: Daniel Rammer <[email protected]>

* updated flytetools branch to master

Signed-off-by: Daniel Rammer <[email protected]>

---------

Signed-off-by: Daniel Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Jul 24, 2023
@hamersaw
Copy dynamicJobSpec from partially completed DynamicTask on recovery (f…
5c7a31d 
…lyteorg#518)

* storing compiled workflow

Signed-off-by: Daniel Rammer <[email protected]>

* working

Signed-off-by: Daniel Rammer <[email protected]>

* added unit tests

Signed-off-by: Daniel Rammer <[email protected]>

* fixed lint issues

Signed-off-by: Daniel Rammer <[email protected]>

* recovering inputs of partially complete dynamic task

Signed-off-by: Daniel Rammer <[email protected]>

* removed dead code

Signed-off-by: Daniel Rammer <[email protected]>

* updated flyteidl version

Signed-off-by: Daniel Rammer <[email protected]>

* returning inputs from recoverInputs function

Signed-off-by: Daniel Rammer <[email protected]>

* fixed tests

Signed-off-by: Daniel Rammer <[email protected]>

* updated flyteidl

Signed-off-by: Daniel Rammer <[email protected]>

---------

Signed-off-by: Daniel Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
@hamersaw
Copy dynamicJobSpec from partially completed DynamicTask on recovery (f…
703dbf2 
…lyteorg#518)

* storing compiled workflow

Signed-off-by: Daniel Rammer <[email protected]>

* working

Signed-off-by: Daniel Rammer <[email protected]>

* added unit tests

Signed-off-by: Daniel Rammer <[email protected]>

* fixed lint issues

Signed-off-by: Daniel Rammer <[email protected]>

* recovering inputs of partially complete dynamic task

Signed-off-by: Daniel Rammer <[email protected]>

* removed dead code

Signed-off-by: Daniel Rammer <[email protected]>

* updated flyteidl version

Signed-off-by: Daniel Rammer <[email protected]>

* returning inputs from recoverInputs function

Signed-off-by: Daniel Rammer <[email protected]>

* fixed tests

Signed-off-by: Daniel Rammer <[email protected]>

* updated flyteidl

Signed-off-by: Daniel Rammer <[email protected]>

---------

Signed-off-by: Daniel Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@hamersaw
Bumping go version to 1.19 (flyteorg#518)
6cbdfce 
* bumping go version to 1.19

Signed-off-by: Daniel Rammer <[email protected]>

* fixed go generatea

Signed-off-by: Daniel Rammer <[email protected]>

* updated flytetools branch to master

Signed-off-by: Daniel Rammer <[email protected]>

---------

Signed-off-by: Daniel Rammer <[email protected]>
@github-actions
Copy link

Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Aug 26, 2023
@github-actions
Copy link

github-actions bot commented Sep 2, 2023

Hello 👋, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 2, 2023
@eapolinario eapolinario reopened this Nov 2, 2023
@github-actions github-actions bot removed the stale label Nov 3, 2023
@github-actions GitHub Actions
Copy link

Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable.
Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yindia yindia

Labels
flyteadmin Issue for FlyteAdmin Service housekeeping Issues that help maintain flyte and keep it tech-debt free stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace kind with sandbox in integration test flyteorg/flyteadmin
6 participants
@EngHabu @eapolinario @katrogan @yindia @kumare3 @pingsutw