Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: return the config file not found error" #6100

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

eapolinario
Copy link
Contributor

Reverts #5972

This change forced a config file to be defined for all invocations of the flyte binaries (flytectl, flyteadmin, flytepropeller, etc). The blast radius of missing a config file is a lot bigger than simply flytectl, so reverting this change for now while we consider other options for the original issue.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 36.99%. Comparing base (ab4290e) to head (5b18d35).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
flytestdlib/config/viper/viper.go 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6100      +/-   ##
==========================================
+ Coverage   35.46%   36.99%   +1.52%     
==========================================
  Files        1001     1318     +317     
  Lines      102093   132406   +30313     
==========================================
+ Hits        36209    48980   +12771     
- Misses      62861    79173   +16312     
- Partials     3023     4253    +1230     
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.10% <ø> (ø)
unittests-flytecopilot 30.99% <ø> (ø)
unittests-flytectl 62.29% <ø> (ø)
unittests-flyteidl 7.23% <ø> (ø)
unittests-flyteplugins 53.82% <ø> (ø)
unittests-flytepropeller 42.60% <ø> (?)
unittests-flytestdlib 55.18% <0.00%> (-2.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario eapolinario enabled auto-merge (squash) December 11, 2024 16:02
katrogan
katrogan previously approved these changes Dec 11, 2024
Signed-off-by: Eduardo Apolinario <[email protected]>
@eapolinario eapolinario merged commit 2a7d363 into master Dec 11, 2024
50 of 52 checks passed
@eapolinario eapolinario deleted the revert-5972-terryhung/fix-the-config-error branch December 11, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants