fix: return the config file not found error #5972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: terry.hung <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5972 +/- ##
==========================================
+ Coverage 36.90% 37.00% +0.10%
==========================================
Files 1310 1310
Lines 131372 131369 -3
==========================================
+ Hits 48477 48610 +133
+ Misses 78682 78526 -156
- Partials 4213 4233 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: terry.hung <[email protected]>
Signed-off-by: terry.hung <[email protected]>
Signed-off-by: terry.hung <[email protected]>
Signed-off-by: terry.hung <[email protected]>
Signed-off-by: terry.hung <[email protected]>
Signed-off-by: terry.hung <[email protected]>
Terryhung
changed the title
3 tasks
eapolinario
added a commit
that referenced
this pull request
Dec 11, 2024
This reverts commit d2ddfe2.
eapolinario
added a commit
that referenced
this pull request
Dec 11, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes #4891
Why are the changes needed?
The changes are needed to handle the situation where flytectl panics when an incorrect configuration path is provided. Currently, passing an invalid or incorrect config path causes flytectl to crash unexpectedly, leading to poor user experience and making debugging difficult.
What changes were proposed in this pull request?
Return the
errordirectly.How was this patch tested?
unit test.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link