Reduce where clause fanout when updating workflow, node & task executions

[katrogan]

Why are the changes needed?

In the executions path, performant updates are important since propeller sends executions events and doesn't proceed with the execution until the event is properly acked.

We've observed a performance increase (3x) for updating task executions in particular (which have 9!! primary keys) so that generated gorm adds a where clause for each primary key and this results in noticeably slower queries compared to updating on the unique BaseModel indexed Id field.

What changes were proposed in this pull request?

I'm only updating executions tables here (workflow, node and task) because they're in the hot path. Inventory like tasks and workflows can't be updated, launch plan state can but the perf requirements there are lower and the expected table size for static inventory is usually much lower than for executions

We can always assume the model has the id filled out because we fetch it before updating

• executions: https://github.com/unionai/flyte/blob/d2f1c2ac3670e45494a60d5653d9bc0c40ec1f9c/flyteadmin/pkg/manager/impl/execution_manager.go#L1931
• node executions: https://github.com/unionai/flyte/blob/d2f1c2ac3670e45494a60d5653d9bc0c40ec1f9c/flyteadmin/pkg/manager/impl/node_execution_manager.go#L258-L274
• task executions: https://github.com/unionai/flyte/blob/d2f1c2ac3670e45494a60d5653d9bc0c40ec1f9c/flyteadmin/pkg/manager/impl/task_execution_manager.go#L155-L189

How was this patch tested?

Tested on sandbox. Verified executions progressed and I could interact with the console. Verified dumped SQL showed updated query.

Setup process

Screenshots

Check all the applicable boxes

• I updated the documentation accordingly.
• All new and existing tests passed.
• All commits are signed-off.

Related PRs

Docs link

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.81%. Comparing base (f745030) to head (3f2f3fe).
Report is 2 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5953   +/-   ##
=======================================
  Coverage   36.81%   36.81%           
=======================================
  Files        1310     1310           
  Lines      131032   131035    +3     
=======================================
+ Hits        48234    48238    +4     
+ Misses      78612    78611    -1     
  Partials     4186     4186           

Flag	Coverage Δ
unittests-datacatalog	51.58% <ø> (ø)
unittests-flyteadmin	54.05% <100.00%> (+<0.01%)	⬆️
unittests-flytecopilot	11.73% <ø> (ø)
unittests-flytectl	62.38% <ø> (ø)
unittests-flyteidl	6.92% <ø> (ø)
unittests-flyteplugins	53.64% <ø> (ø)
unittests-flytepropeller	42.90% <ø> (ø)
unittests-flytestdlib	55.41% <ø> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.