Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Implement LaunchPlanAttributes #543

Open
1 of 13 tasks
katrogan opened this issue Oct 8, 2020 · 7 comments
Open
1 of 13 tasks

[Feature] Implement LaunchPlanAttributes #543

katrogan opened this issue Oct 8, 2020 · 7 comments
Labels
enhancement New feature or request stale

Comments

@katrogan
Copy link
Contributor

katrogan commented Oct 8, 2020

Motivation: Why do you think this is important?
Much like project_domain_attributes and workflow_attributes, matchable attributes should be updatable via the admin UI for launch plan entities too.

Goal: What should the final outcome look like, ideally?
It should be possible to set and get launch plan matchable attributes.

Describe alternatives you've considered

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

[Optional] Propose: Link/Inline
If you have ideas about the implementation please propose the change. If inline keep it short, if larger then you link to an external document.

Additional context
Add any other context or screenshots about the feature request here.

Is this a blocker for you to adopt Flyte
Please let us know if this makes it impossible to adopt Flyte

@katrogan katrogan added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Oct 8, 2020
@katrogan
Copy link
Contributor Author

katrogan commented Oct 8, 2020

cc @akhurana001

@akhurana001
Copy link
Contributor

🙏 Thanks for filing this

@kumare3 kumare3 removed the untriaged This issues has not yet been looked at by the Maintainers label Mar 1, 2021
@kumare3
Copy link
Contributor

kumare3 commented Mar 1, 2021

@akhurana001 / @katrogan can you add a little more detail on this - is this not possible today? If not why not?

@akhurana001
Copy link
Contributor

@kumare3 From what i remember, this was to add support for LaunchPlan level routing/configuration in update_execution_cluster_label CLI: https://github.com/flyteorg/flytekit/blob/master/flytekit/clis/flyte_cli/main.py#L2027

eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Jul 24, 2023
…teorg#543)

* waiting for upstream nodes on branch subnode evaluation

Signed-off-by: Daniel Rammer <[email protected]>

* removed dead comments

Signed-off-by: Daniel Rammer <[email protected]>

* added unit test

Signed-off-by: Daniel Rammer <[email protected]>

* fixed lint issues

Signed-off-by: Daniel Rammer <[email protected]>

---------

Signed-off-by: Daniel Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
…teorg#543)

* waiting for upstream nodes on branch subnode evaluation

Signed-off-by: Daniel Rammer <[email protected]>

* removed dead comments

Signed-off-by: Daniel Rammer <[email protected]>

* added unit test

Signed-off-by: Daniel Rammer <[email protected]>

* fixed lint issues

Signed-off-by: Daniel Rammer <[email protected]>

---------

Signed-off-by: Daniel Rammer <[email protected]>
@github-actions
Copy link

Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Aug 26, 2023
@github-actions
Copy link

github-actions bot commented Sep 2, 2023

Hello 👋, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 2, 2023
@eapolinario eapolinario reopened this Nov 2, 2023
@github-actions github-actions bot removed the stale label Nov 3, 2023
Copy link

Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable.
Thank you for your contribution and understanding! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

4 participants