-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update aws-go-sdk to v1.47.11 to support EKS Pod Identity #5796
Update aws-go-sdk to v1.47.11 to support EKS Pod Identity #5796
Conversation
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Signed-off-by: Matt <[email protected]>
1603f2e
to
4c92575
Compare
I didn't want to contaminate the OP, but for the interested, this is the same place testing failed on, regardless of my changes or latest release.
|
I just kicked off the CI so we can see if it fails the unit tests there. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5796 +/- ##
==========================================
+ Coverage 36.31% 36.35% +0.03%
==========================================
Files 1304 1304
Lines 110048 110147 +99
==========================================
+ Hits 39964 40042 +78
- Misses 65928 65938 +10
- Partials 4156 4167 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Matt <[email protected]>
826df36
to
7ede8a6
Compare
Thanks for that. Some of the failures are related to missing an update in |
@Sovietaced It looks like it passed all the required tests, and the only failures seem to be related to code coverage which are unrelated to my changes. Any chance this gets an approval and merge? Would be nice to get this in for the next release. |
I'm going to take a look at the unit test failure. codecov usually fails until all the actions run and then it passes |
I re-ran the failed test and it passed. Not sure what happened. I'm actually just a committer and although I can merge this I'd like to connect with the Flyte folks to see if I'm missing anything. |
) Signed-off-by: Siddhant Rai <[email protected]>
* Update registering_workflows.md Signed-off-by: Siddhant Rai <[email protected]> * feat: note in registering_workflows for k8sPod.dataConfig fix Signed-off-by: Siddhant Rai <[email protected]> * update: remove note as requested change Signed-off-by: Siddhant Rai <[email protected]> Signed-off-by: Siddhant Rai <[email protected]> * Flyte docs overhaul (phase 1) (#5772) * move flytekit and flytectl docs into API section Signed-off-by: nikki everett <[email protected]> * switch to docsearch module and env variables Signed-off-by: nikki everett <[email protected]> * reorganize content for pydata theme Signed-off-by: nikki everett <[email protected]> * more docs reorganization Signed-off-by: nikki everett <[email protected]> * switch to pydata theme Signed-off-by: nikki everett <[email protected]> * reorganize concepts/glossary and ecosystem docs Signed-off-by: nikki everett <[email protected]> * remove unneeded custom CSS and JS files Signed-off-by: nikki everett <[email protected]> * add redirects Signed-off-by: nikki everett <[email protected]> * add more redirects Signed-off-by: nikki everett <[email protected]> * first pass at updating docs contributing guide Signed-off-by: nikki everett <[email protected]> * remove core use cases Signed-off-by: nikki everett <[email protected]> * more edits to docs contributing guide Signed-off-by: nikki everett <[email protected]> * more edits to the flytesnacks contributing guide Signed-off-by: nikki everett <[email protected]> * add content to API reference index page, use consistent title and format for API reference section titles Signed-off-by: nikki everett <[email protected]> * rename deployment section Signed-off-by: nikki everett <[email protected]> * reorganize sections Signed-off-by: nikki everett <[email protected]> * fix typos Signed-off-by: nikki everett <[email protected]> * add docsearch index name and app id Signed-off-by: nikki everett <[email protected]> * add ref to docs contributing doc and move all docsearch stuff to env vars again Signed-off-by: nikki everett <[email protected]> * docs overhaul: render flyteidl under the /api/ path (#5802) * fix flyteidl structure so it renders under /api/ Signed-off-by: Niels Bantilan <[email protected]> * do not check in flyteidl docs Signed-off-by: Niels Bantilan <[email protected]> * update gitignore and unneeded conf Signed-off-by: Niels Bantilan <[email protected]> * add mock DOCSEARCH_API_KEY to docs test ci Signed-off-by: Niels Bantilan <[email protected]> * add css styling (#5803) * add css styling Signed-off-by: Niels Bantilan <[email protected]> * update logo height Signed-off-by: Niels Bantilan <[email protected]> --------- Signed-off-by: Niels Bantilan <[email protected]> --------- Signed-off-by: Niels Bantilan <[email protected]> * use same icon as union docs Signed-off-by: nikki everett <[email protected]> * sp error Signed-off-by: Niels Bantilan <[email protected]> --------- Signed-off-by: nikki everett <[email protected]> Signed-off-by: Niels Bantilan <[email protected]> Co-authored-by: Niels Bantilan <[email protected]> Signed-off-by: Siddhant Rai <[email protected]> * [Flyte][3][flytepropeller][Attribute Access][flytectl] Binary IDL With MessagePack (#5763) Signed-off-by: Siddhant Rai <[email protected]> * Update aws-go-sdk to v1.47.11 to support EKS Pod Identity (#5796) Signed-off-by: Siddhant Rai <[email protected]> * Update docs/user_guide/flyte_fundamentals/registering_workflows.md Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Siddhant Rai <[email protected]> * Update registering_workflows.md Signed-off-by: Siddhant Rai <[email protected]> --------- Signed-off-by: Siddhant Rai <[email protected]> Signed-off-by: Siddhant Rai <[email protected]> Signed-off-by: nikki everett <[email protected]> Signed-off-by: Niels Bantilan <[email protected]> Co-authored-by: Nikki Everett <[email protected]> Co-authored-by: Niels Bantilan <[email protected]> Co-authored-by: Future-Outlier <[email protected]> Co-authored-by: mthemis-provenir <[email protected]>
Tracking issue
Closes #5794
Why are the changes needed?
Updates the AWS Go SDK to support EKS Pod Identity, a newer, more convenient way of authenticating service accounts to IAM roles.
What changes were proposed in this pull request?
To bring the AWS Go SDK up to the minimum required to support the feature.
How was this patch tested?
I tried to test the various modules however I kept getting the same error, so I then checked out the latest release (v1.13.1), reran everything and it failed at the same place, which makes me think it's something wrong with my setup. I did have to edit the PostgreSQL and Minio deployments because they aren't compatible with arm64, so it might be due to that. I'd very much appreciate it if anyone with a working environment could give this a quick test.
Check all the applicable boxes
Related PRs
N/A
Docs link
None added, but can look to add documentation if desired.