-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flyte docs overhaul (phase 1) #5772
Conversation
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5772 +/- ##
=======================================
Coverage 36.31% 36.31%
=======================================
Files 1304 1304
Lines 110072 110072
=======================================
Hits 39974 39974
Misses 65936 65936
Partials 4162 4162
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This look great!
I know that this version is not meant to address every formatting or content problem but there are a few things I think we should fix before we roll this out:
- Section title "API reference" -> "Flytekit API"
- Can we make it go directly to the Flytekit API page when the top nav item is clicked? Currently it goes to an empty page where you have to make one more click to go to the Flytekit API page
- The title "FlyteIDL API Reference" should be shortened to "FlyteIDL API"
- "Deployment Guide" -> "Deployment guide"
- The "Section Navigation" headings above the left nav should be the same as the top level nav titles
…mat for API reference section titles Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
…vars again Signed-off-by: nikki everett <[email protected]>
* fix flyteidl structure so it renders under /api/ Signed-off-by: Niels Bantilan <[email protected]> * do not check in flyteidl docs Signed-off-by: Niels Bantilan <[email protected]> * update gitignore and unneeded conf Signed-off-by: Niels Bantilan <[email protected]> * add mock DOCSEARCH_API_KEY to docs test ci Signed-off-by: Niels Bantilan <[email protected]> * add css styling (#5803) * add css styling Signed-off-by: Niels Bantilan <[email protected]> * update logo height Signed-off-by: Niels Bantilan <[email protected]> --------- Signed-off-by: Niels Bantilan <[email protected]> --------- Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
* move flytekit and flytectl docs into API section Signed-off-by: nikki everett <[email protected]> * switch to docsearch module and env variables Signed-off-by: nikki everett <[email protected]> * reorganize content for pydata theme Signed-off-by: nikki everett <[email protected]> * more docs reorganization Signed-off-by: nikki everett <[email protected]> * switch to pydata theme Signed-off-by: nikki everett <[email protected]> * reorganize concepts/glossary and ecosystem docs Signed-off-by: nikki everett <[email protected]> * remove unneeded custom CSS and JS files Signed-off-by: nikki everett <[email protected]> * add redirects Signed-off-by: nikki everett <[email protected]> * add more redirects Signed-off-by: nikki everett <[email protected]> * first pass at updating docs contributing guide Signed-off-by: nikki everett <[email protected]> * remove core use cases Signed-off-by: nikki everett <[email protected]> * more edits to docs contributing guide Signed-off-by: nikki everett <[email protected]> * more edits to the flytesnacks contributing guide Signed-off-by: nikki everett <[email protected]> * add content to API reference index page, use consistent title and format for API reference section titles Signed-off-by: nikki everett <[email protected]> * rename deployment section Signed-off-by: nikki everett <[email protected]> * reorganize sections Signed-off-by: nikki everett <[email protected]> * fix typos Signed-off-by: nikki everett <[email protected]> * add docsearch index name and app id Signed-off-by: nikki everett <[email protected]> * add ref to docs contributing doc and move all docsearch stuff to env vars again Signed-off-by: nikki everett <[email protected]> * docs overhaul: render flyteidl under the /api/ path (flyteorg#5802) * fix flyteidl structure so it renders under /api/ Signed-off-by: Niels Bantilan <[email protected]> * do not check in flyteidl docs Signed-off-by: Niels Bantilan <[email protected]> * update gitignore and unneeded conf Signed-off-by: Niels Bantilan <[email protected]> * add mock DOCSEARCH_API_KEY to docs test ci Signed-off-by: Niels Bantilan <[email protected]> * add css styling (flyteorg#5803) * add css styling Signed-off-by: Niels Bantilan <[email protected]> * update logo height Signed-off-by: Niels Bantilan <[email protected]> --------- Signed-off-by: Niels Bantilan <[email protected]> --------- Signed-off-by: Niels Bantilan <[email protected]> * use same icon as union docs Signed-off-by: nikki everett <[email protected]> * sp error Signed-off-by: Niels Bantilan <[email protected]> --------- Signed-off-by: nikki everett <[email protected]> Signed-off-by: Niels Bantilan <[email protected]> Co-authored-by: Niels Bantilan <[email protected]> Signed-off-by: Siddhant Rai <[email protected]>
* Update registering_workflows.md Signed-off-by: Siddhant Rai <[email protected]> * feat: note in registering_workflows for k8sPod.dataConfig fix Signed-off-by: Siddhant Rai <[email protected]> * update: remove note as requested change Signed-off-by: Siddhant Rai <[email protected]> Signed-off-by: Siddhant Rai <[email protected]> * Flyte docs overhaul (phase 1) (#5772) * move flytekit and flytectl docs into API section Signed-off-by: nikki everett <[email protected]> * switch to docsearch module and env variables Signed-off-by: nikki everett <[email protected]> * reorganize content for pydata theme Signed-off-by: nikki everett <[email protected]> * more docs reorganization Signed-off-by: nikki everett <[email protected]> * switch to pydata theme Signed-off-by: nikki everett <[email protected]> * reorganize concepts/glossary and ecosystem docs Signed-off-by: nikki everett <[email protected]> * remove unneeded custom CSS and JS files Signed-off-by: nikki everett <[email protected]> * add redirects Signed-off-by: nikki everett <[email protected]> * add more redirects Signed-off-by: nikki everett <[email protected]> * first pass at updating docs contributing guide Signed-off-by: nikki everett <[email protected]> * remove core use cases Signed-off-by: nikki everett <[email protected]> * more edits to docs contributing guide Signed-off-by: nikki everett <[email protected]> * more edits to the flytesnacks contributing guide Signed-off-by: nikki everett <[email protected]> * add content to API reference index page, use consistent title and format for API reference section titles Signed-off-by: nikki everett <[email protected]> * rename deployment section Signed-off-by: nikki everett <[email protected]> * reorganize sections Signed-off-by: nikki everett <[email protected]> * fix typos Signed-off-by: nikki everett <[email protected]> * add docsearch index name and app id Signed-off-by: nikki everett <[email protected]> * add ref to docs contributing doc and move all docsearch stuff to env vars again Signed-off-by: nikki everett <[email protected]> * docs overhaul: render flyteidl under the /api/ path (#5802) * fix flyteidl structure so it renders under /api/ Signed-off-by: Niels Bantilan <[email protected]> * do not check in flyteidl docs Signed-off-by: Niels Bantilan <[email protected]> * update gitignore and unneeded conf Signed-off-by: Niels Bantilan <[email protected]> * add mock DOCSEARCH_API_KEY to docs test ci Signed-off-by: Niels Bantilan <[email protected]> * add css styling (#5803) * add css styling Signed-off-by: Niels Bantilan <[email protected]> * update logo height Signed-off-by: Niels Bantilan <[email protected]> --------- Signed-off-by: Niels Bantilan <[email protected]> --------- Signed-off-by: Niels Bantilan <[email protected]> * use same icon as union docs Signed-off-by: nikki everett <[email protected]> * sp error Signed-off-by: Niels Bantilan <[email protected]> --------- Signed-off-by: nikki everett <[email protected]> Signed-off-by: Niels Bantilan <[email protected]> Co-authored-by: Niels Bantilan <[email protected]> Signed-off-by: Siddhant Rai <[email protected]> * [Flyte][3][flytepropeller][Attribute Access][flytectl] Binary IDL With MessagePack (#5763) Signed-off-by: Siddhant Rai <[email protected]> * Update aws-go-sdk to v1.47.11 to support EKS Pod Identity (#5796) Signed-off-by: Siddhant Rai <[email protected]> * Update docs/user_guide/flyte_fundamentals/registering_workflows.md Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Siddhant Rai <[email protected]> * Update registering_workflows.md Signed-off-by: Siddhant Rai <[email protected]> --------- Signed-off-by: Siddhant Rai <[email protected]> Signed-off-by: Siddhant Rai <[email protected]> Signed-off-by: nikki everett <[email protected]> Signed-off-by: Niels Bantilan <[email protected]> Co-authored-by: Nikki Everett <[email protected]> Co-authored-by: Niels Bantilan <[email protected]> Co-authored-by: Future-Outlier <[email protected]> Co-authored-by: mthemis-provenir <[email protected]>
Tracking issue
This is phase 1 in a multi-phase project to overhaul the Flyte docs to make them easier to maintain and contribute to, and more useful and usable for readers.
To test these changes locally, you will need to do the following:
conda env update --file monodocs-environment.lock.yaml
nikki/docs/refresh
branchFLYTESNACKS_LOCAL_PATH
environment variable to the location of your local copy of flytesnacksNote: The monodocs build will fail for this PR until the linked flytesnacks PR is merged.
Why are the changes needed?
These changes make the Flyte docs easier to maintain and contribute to and lay the groundwork for phase 2 of the Flyte docs overhaul project, in which we'll significantly update the content itself to be more useful, usable, and accurate for readers. They also bring the Flyte docs into closer alignment with Union docs by switching the theme from furo to pydata.
What changes were proposed in this pull request?
Note: I removed the old version switcher, since it was part of the old theme. I will add the pydata-specific version switcher in phase 2. (The current version switcher is only partially usable at the moment -- the links are only visible in dark mode, and dark mode is not available in Chrome or Safari -- so although this is a regression, it's not a major one.)
Screenshots from local build
Landing page
User guide section
How was this patch tested?
Tested locally.
Check all the applicable boxes
Related PRs
flyteorg/flytesnacks#1726
Docs link
https://flyte--5772.org.readthedocs.build/en/5772/ (Tutorials and integrations will not appear in this build, because we're pulling from flytesnacks master, not the flytesnacks docs overhaul branch.)