Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi file error aggregation strategy #5795

Merged
merged 34 commits into from
Nov 5, 2024

resolve merge conflits

d4846f4
Select commit
Loading
Failed to load commit list.
Merged

Add multi file error aggregation strategy #5795

resolve merge conflits
d4846f4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Nov 5, 2024 in 0s

60.00% of diff hit (target 36.81%)

View this Pull Request on Codecov

60.00% of diff hit (target 36.81%)

Annotations

Check warning on line 156 in flyteidl/gen/pb-go/flyteidl/core/errors.pb.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteidl/gen/pb-go/flyteidl/core/errors.pb.go#L152-L156 

Added lines #L152 - L156 were not covered by tests

Check warning on line 163 in flyteidl/gen/pb-go/flyteidl/core/errors.pb.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteidl/gen/pb-go/flyteidl/core/errors.pb.go#L159-L163 

Added lines #L159 - L163 were not covered by tests

Check warning on line 588 in flyteidl/gen/pb-go/flyteidl/core/execution.pb.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteidl/gen/pb-go/flyteidl/core/execution.pb.go#L584-L588 

Added lines #L584 - L588 were not covered by tests

Check warning on line 595 in flyteidl/gen/pb-go/flyteidl/core/execution.pb.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteidl/gen/pb-go/flyteidl/core/execution.pb.go#L591-L595 

Added lines #L591 - L595 were not covered by tests

Check warning on line 89 in flyteplugins/go/tasks/pluginmachinery/ioutils/remote_file_output_reader.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/pluginmachinery/ioutils/remote_file_output_reader.go#L87-L89 

Added lines #L87 - L89 were not covered by tests

Check warning on line 104 in flyteplugins/go/tasks/pluginmachinery/ioutils/remote_file_output_reader.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/pluginmachinery/ioutils/remote_file_output_reader.go#L95-L104 

Added lines #L95 - L104 were not covered by tests

Check warning on line 117 in flyteplugins/go/tasks/pluginmachinery/ioutils/remote_file_output_reader.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/pluginmachinery/ioutils/remote_file_output_reader.go#L109-L117 

Added lines #L109 - L117 were not covered by tests

Check warning on line 143 in flyteplugins/go/tasks/pluginmachinery/ioutils/remote_file_output_reader.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/pluginmachinery/ioutils/remote_file_output_reader.go#L143 

Added line #L143 was not covered by tests

Check warning on line 149 in flyteplugins/go/tasks/pluginmachinery/ioutils/remote_file_output_reader.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/pluginmachinery/ioutils/remote_file_output_reader.go#L149 

Added line #L149 was not covered by tests

Check warning on line 165 in flyteplugins/go/tasks/pluginmachinery/ioutils/remote_file_output_reader.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/pluginmachinery/ioutils/remote_file_output_reader.go#L164-L165 

Added lines #L164 - L165 were not covered by tests

Check warning on line 171 in flyteplugins/go/tasks/pluginmachinery/ioutils/remote_file_output_reader.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/pluginmachinery/ioutils/remote_file_output_reader.go#L170-L171 

Added lines #L170 - L171 were not covered by tests

Check warning on line 175 in flyteplugins/go/tasks/pluginmachinery/ioutils/remote_file_output_reader.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/pluginmachinery/ioutils/remote_file_output_reader.go#L174-L175 

Added lines #L174 - L175 were not covered by tests

Check warning on line 194 in flyteplugins/go/tasks/pluginmachinery/ioutils/remote_file_output_reader.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/pluginmachinery/ioutils/remote_file_output_reader.go#L193-L194 

Added lines #L193 - L194 were not covered by tests

Check warning on line 197 in flyteplugins/go/tasks/pluginmachinery/ioutils/remote_file_output_reader.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/pluginmachinery/ioutils/remote_file_output_reader.go#L197 

Added line #L197 was not covered by tests

Check warning on line 203 in flyteplugins/go/tasks/pluginmachinery/ioutils/remote_file_output_reader.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/pluginmachinery/ioutils/remote_file_output_reader.go#L202-L203 

Added lines #L202 - L203 were not covered by tests

Check warning on line 220 in flyteplugins/go/tasks/pluginmachinery/ioutils/remote_file_output_reader.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/pluginmachinery/ioutils/remote_file_output_reader.go#L219-L220 

Added lines #L219 - L220 were not covered by tests

Check warning on line 244 in flyteplugins/go/tasks/pluginmachinery/ioutils/remote_file_output_reader.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/pluginmachinery/ioutils/remote_file_output_reader.go#L239-L244 

Added lines #L239 - L244 were not covered by tests

Check warning on line 249 in flyteplugins/go/tasks/pluginmachinery/ioutils/remote_file_output_reader.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/pluginmachinery/ioutils/remote_file_output_reader.go#L249 

Added line #L249 was not covered by tests

Check warning on line 340 in flyteplugins/go/tasks/pluginmachinery/ioutils/remote_file_output_reader.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/pluginmachinery/ioutils/remote_file_output_reader.go#L340 

Added line #L340 was not covered by tests

Check warning on line 347 in flyteplugins/go/tasks/pluginmachinery/ioutils/remote_file_output_reader.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/pluginmachinery/ioutils/remote_file_output_reader.go#L346-L347 

Added lines #L346 - L347 were not covered by tests

Check warning on line 46 in flyteplugins/go/tasks/pluginmachinery/k8s/plugin.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/pluginmachinery/k8s/plugin.go#L45-L46 

Added lines #L45 - L46 were not covered by tests

Check warning on line 50 in flyteplugins/go/tasks/pluginmachinery/k8s/plugin.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/pluginmachinery/k8s/plugin.go#L49-L50 

Added lines #L49 - L50 were not covered by tests

Check warning on line 109 in flyteplugins/go/tasks/plugins/k8s/kfoperators/pytorch/pytorch.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/kfoperators/pytorch/pytorch.go#L108-L109 

Added lines #L108 - L109 were not covered by tests

Check warning on line 302 in flytepropeller/pkg/controller/nodes/task/k8s/plugin_manager.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/controller/nodes/task/k8s/plugin_manager.go#L301-L302 

Added lines #L301 - L302 were not covered by tests

Check warning on line 305 in flytestdlib/storage/stow_store.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytestdlib/storage/stow_store.go#L305 

Added line #L305 was not covered by tests
View more details on Codecov