Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi file error aggregation strategy #5795

Merged
merged 34 commits into from
Nov 5, 2024

resolve merge conflits

d4846f4
Select commit
Loading
Failed to load commit list.
Merged

Add multi file error aggregation strategy #5795

resolve merge conflits
d4846f4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 5, 2024 in 1s

36.85% (+0.04%) compared to 636cc23

View this Pull Request on Codecov

36.85% (+0.04%) compared to 636cc23

Details

Codecov Report

Attention: Patch coverage is 60.00000% with 90 lines in your changes missing coverage. Please review.

Project coverage is 36.85%. Comparing base (636cc23) to head (d4846f4).

Files with missing lines Patch % Lines
...uginmachinery/ioutils/remote_file_output_reader.go 63.80% 47 Missing and 12 partials ⚠️
flyteidl/gen/pb-go/flyteidl/core/errors.pb.go 0.00% 10 Missing ⚠️
flyteidl/gen/pb-go/flyteidl/core/execution.pb.go 0.00% 10 Missing ⚠️
...lyteplugins/go/tasks/pluginmachinery/k8s/plugin.go 50.00% 4 Missing ⚠️
...o/tasks/plugins/k8s/kfoperators/pytorch/pytorch.go 85.71% 2 Missing and 1 partial ⚠️
...er/pkg/controller/nodes/task/k8s/plugin_manager.go 50.00% 2 Missing and 1 partial ⚠️
flytestdlib/storage/stow_store.go 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5795      +/-   ##
==========================================
+ Coverage   36.81%   36.85%   +0.04%     
==========================================
  Files        1310     1310              
  Lines      131034   131217     +183     
==========================================
+ Hits        48237    48361     +124     
- Misses      78611    78658      +47     
- Partials     4186     4198      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov