Fix lint errors caught by chart-testing

[eapolinario]

Tracking issue

NA

Why are the changes needed?

We enabled chart testing in #5027, but never got around fixing the lint errors caught by that check. This PR fixes the first batch of errors.

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

• I updated the documentation accordingly.
• All new and existing tests passed.
• All commits are signed-off.

Related PRs

Docs link

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.98%. Comparing base (eb24107) to head (7aa0a5d).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5072      +/-   ##
==========================================
- Coverage   58.98%   58.98%   -0.01%     
==========================================
  Files         645      645              
  Lines       55590    55590              
==========================================
- Hits        32791    32788       -3     
- Misses      20204    20208       +4     
+ Partials     2595     2594       -1     

Flag	Coverage Δ
unittests	58.98% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[lowc1012]

@eapolinario thanks
I also created a PR for this issue.
#5068

[eapolinario]

@eapolinario thanks I also created a PR for this issue. #5068

oh nice, thank you. I didn't notice you were also fixing this. I took a look and it looks like we're duplicating some areas (sorry about that!). Unfortunately we need those comments (e.g. # FLYTECONSOLE_TAG or # FLYTEPROPELLER_TAG) as those are used as part of the release process.

[davidmirror-ops]

Is there a way to test this?
Thanks!

[eapolinario]

Is there a way to test this? Thanks!

Are you asking about testing this locally? If so, I'm adding a make target that runs this job locally using act. This will help us iterate locally (and decrease the discrepancy between CI and local runs).