-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add first version of gke-starter values file #5026
add first version of gke-starter values file #5026
Conversation
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5026 +/- ##
==========================================
- Coverage 58.99% 58.99% -0.01%
==========================================
Files 645 645
Lines 55648 55648
==========================================
- Hits 32831 32830 -1
- Misses 20222 20223 +1
Partials 2595 2595
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. Thank you!
For the failing Helm test, can you try running |
When I try to run
And creates no changes that I can commit |
@cjidboon94 , can you merge master (to bring in d5784e5) and re-run? |
858bd36
to
71e8271
Compare
I see new tests failing after having bumped up the chart. Should I have done that? Or should I revert/undo the latest commit? |
@cjidboon94 Please revert :) |
@cjidboon94 @davidmirror-ops |
@davidmirror-ops @pingsutw @cjidboon94 |
2f4cd0d
to
65b069d
Compare
Signed-off-by: Cornelis Boon <[email protected]>
…templateUri Signed-off-by: Cornelis Boon <[email protected]>
Signed-off-by: Cornelis Boon <[email protected]>
Signed-off-by: Cornelis Boon <[email protected]>
Signed-off-by: Cornelis Boon <[email protected]>
Signed-off-by: Cornelis Boon <[email protected]>
This reverts commit ddfe840. Signed-off-by: Cornelis Boon <[email protected]>
Signed-off-by: Cornelis Boon <[email protected]>
…tance GPUs in GKE Signed-off-by: Cornelis Boon <[email protected]>
Signed-off-by: Cornelis Boon <[email protected]>
65b069d
to
1224e69
Compare
Signed-off-by: Cornelis Boon <[email protected]>
@davidmirror-ops Since #5072 is merged, I have rebased myself onto the new master and the tests aren't failing anymore. I think this is ready to merge now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Congrats on merging your first pull request! 🎉 |
* add first version of gke-starter values file Signed-off-by: Cornelis Boon <[email protected]> * remove AWS metadata env var, add service account annotations, update templateUri Signed-off-by: Cornelis Boon <[email protected]> * let user fill in GCP project ID in templateUri Signed-off-by: Cornelis Boon <[email protected]> * add link to GCP workload identity configuration Signed-off-by: Cornelis Boon <[email protected]> * run make helm Signed-off-by: Cornelis Boon <[email protected]> * bump flyte-binary chart version to v0.1.11 Signed-off-by: Cornelis Boon <[email protected]> * Revert "bump flyte-binary chart version to v0.1.11" This reverts commit ddfe840. Signed-off-by: Cornelis Boon <[email protected]> * add default configuration to allow scheduling on gpu nodes in GKE Signed-off-by: Cornelis Boon <[email protected]> * add default gpu-partition-size label to allow scheduling on multi-instance GPUs in GKE Signed-off-by: Cornelis Boon <[email protected]> * run make helm Signed-off-by: Cornelis Boon <[email protected]> * fix linting errors Signed-off-by: Cornelis Boon <[email protected]> --------- Signed-off-by: Cornelis Boon <[email protected]>
Tracking issue
#5016
Closes #5016
Why are the changes needed?
There are examples of how to deploy flyte minimally on AWS/EKS described in Single Cluster Simple Cloud Deployment but not for GCP/GKE.
This values file makes it easier for new people to deploy.
What changes were proposed in this pull request?
A minimal value file with default settings filled in for a minimal deployment on GKE/GCP using the flyte-binary chart
How was this patch tested?
I used it to deploy on GKE.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link