Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Open external links in new tab #4966

Merged

Conversation

MortalHappiness
Copy link
Member

Tracking issue

#4909

Resolves: #4909

Why are the changes needed?

See the description in the corresponding issue.

What changes were proposed in this pull request?

Open all external links in new tab.

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. documentation Improvements or additions to documentation labels Feb 27, 2024
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.30%. Comparing base (a5e2733) to head (a171c70).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4966      +/-   ##
==========================================
+ Coverage   59.03%   59.30%   +0.27%     
==========================================
  Files         645      645              
  Lines       55726    52614    -3112     
==========================================
- Hits        32896    31201    -1695     
+ Misses      20233    18816    -1417     
  Partials     2597     2597              
Flag Coverage Δ
unittests 59.93% <ø> (+0.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MortalHappiness MortalHappiness changed the title Docs: Open external links in new tab [Docs] Open external links in new tab Feb 28, 2024
@MortalHappiness MortalHappiness force-pushed the docs/#4909-external-link-new-tab branch from 2b17faf to 3dabab9 Compare February 28, 2024 14:23
neverett
neverett previously approved these changes Feb 29, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 29, 2024
pingsutw
pingsutw previously approved these changes Mar 4, 2024
@MortalHappiness MortalHappiness dismissed stale reviews from pingsutw and neverett via a171c70 March 27, 2024 10:45
@MortalHappiness MortalHappiness force-pushed the docs/#4909-external-link-new-tab branch from 3dabab9 to a171c70 Compare March 27, 2024 10:45
@eapolinario eapolinario enabled auto-merge (squash) March 27, 2024 18:50
@eapolinario eapolinario merged commit 5de1a02 into flyteorg:master Mar 27, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Links in sidebar with new window icon should open in a new window
4 participants