Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Links in sidebar with new window icon should open in a new window #4909

Closed
2 tasks done
MortalHappiness opened this issue Feb 16, 2024 · 3 comments · Fixed by #4966
Closed
2 tasks done

[Docs] Links in sidebar with new window icon should open in a new window #4909

MortalHappiness opened this issue Feb 16, 2024 · 3 comments · Fixed by #4966
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@MortalHappiness
Copy link
Member

Description

These links with new window icons should open in a new window. However, they open in the current window.

image

image

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@MortalHappiness MortalHappiness added documentation Improvements or additions to documentation untriaged This issues has not yet been looked at by the Maintainers labels Feb 16, 2024
Copy link

welcome bot commented Feb 16, 2024

Thank you for opening your first issue here! 🛠

Copy link

dosubot bot commented Feb 16, 2024

🤖

Hey @MortalHappiness! Good to see you back with us. I hope you've been well since our last adventure!

Thank you for bringing this to our attention. It seems like the links with the new window icons in the Flyte documentation sidebar are currently opening in the same window, which is not the expected behavior.

The behavior of these links is typically controlled by the target attribute in the HTML anchor tag. If the target attribute is set to _blank, the link should open in a new window or tab. However, I wasn't able to find the specific HTML or Markdown syntax used for these links in the Flyte repository.

Additionally, there could be a JavaScript function or event handler associated with these links that overrides the default behavior. Unfortunately, I wasn't able to find any such function or event handler in the repository.

To resolve this issue, we would need to ensure that the target attribute for these links is set to _blank. If there is a JavaScript function or event handler associated with these links, we would need to modify it to not override the target attribute.

However, without more information, it's difficult to provide a more specific solution. Could you please provide the HTML or Markdown syntax used for these links, or any associated JavaScript functions or event handlers? This would help us understand the issue better and provide a more accurate solution.

Please note that any changes would need to be made in accordance with the existing CSS rules for the sidebar links, as detailed in the flyte.css file in the repository.

I hope this helps! If you have any more questions or need further clarification, feel free to ask.

Sources

About Dosu

This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

@dosubot dosubot bot added the bug Something isn't working label Feb 16, 2024
@pingsutw pingsutw removed the untriaged This issues has not yet been looked at by the Maintainers label Feb 16, 2024
@MortalHappiness
Copy link
Member Author

#self-assign

MortalHappiness added a commit to MortalHappiness/flyte that referenced this issue Feb 27, 2024
MortalHappiness added a commit to MortalHappiness/flyte that referenced this issue Feb 28, 2024
MortalHappiness added a commit to MortalHappiness/flyte that referenced this issue Mar 27, 2024
eapolinario pushed a commit that referenced this issue Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants