Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monodocs uses flytekit/flytectl index rst file #4720

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

cosmicBboy
Copy link
Contributor

The purpose of this PR is to use docs toctree files that are in the flytectl and flytekit repos respectively. This is so that content changes can occur exclusively in these repos without requiring changes to the flyte repo.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. documentation Improvements or additions to documentation labels Jan 11, 2024
@@ -337,6 +337,7 @@
"flytesnacks/tutorials",
"flytesnacks/integrations",
],
"dev_build": bool(int(os.environ.get("MONODOCS_DEV_BUILD", 1))),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will set this to 0 by default when the next flyte release happens

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (75c2b08) 58.15% compared to head (ac99c44) 58.14%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4720      +/-   ##
==========================================
- Coverage   58.15%   58.14%   -0.01%     
==========================================
  Files         626      626              
  Lines       53786    53786              
==========================================
- Hits        31277    31274       -3     
- Misses      20001    20003       +2     
- Partials     2508     2509       +1     
Flag Coverage Δ
unittests 58.14% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 12, 2024
@cosmicBboy cosmicBboy merged commit c8351be into master Jan 12, 2024
44 of 45 checks passed
@cosmicBboy cosmicBboy deleted the monodocs-repo-docsindex branch January 12, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants