-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add accelerator docs #4713
add accelerator docs #4713
Conversation
Signed-off-by: Niels Bantilan <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4713 +/- ##
=======================================
Coverage 58.13% 58.14%
=======================================
Files 626 626
Lines 53786 53786
=======================================
+ Hits 31271 31276 +5
+ Misses 20007 20002 -5
Partials 2508 2508
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Niels Bantilan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like flyte
needs to be manually updated when a new top level document is added to flytekit
. Can docs/reference_flytekit.md
be generated from something checked into from flytekit
?
Yeah we can add a new top-level index page to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The failing CI test looks related. Is this expected?
I am closing this PR because the issue was resolved in #4720 |
Pull request was closed
This PR adds accelerator docs to the monodocs toctree.