[Docs] Update Development Environment Setup Guide for MonoRepo #4257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Future Outlier <[email protected]>
Future-Outlier
changed the title
Signed-off-by: Future Outlier <[email protected]>
pingsutw
reviewed
Oct 18, 2023
added 2 commits
October 18, 2023 15:21
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
|
@pingsutw, can this PR be merged now? |
pingsutw
approved these changes
Oct 25, 2023
| # Step 3.2: Generate code, fix lint errors and run unit tests for {flyteadmin}. | ||
| # Note, flyteidl does not have unit tests, so you can skip the `make test_unit` command. | ||
| # Note, flytestdlib only have `make generate` command. | ||
| make generate |
There was a problem hiding this comment.
@Future-Outlier I think we still need to execute the following commands:
make generate
make lint
make test_unitFor instance, to generate the protobuf code, I guess we still need to run make generate under flyteidl folder? Correct me if I am wrong.
There was a problem hiding this comment.
Yes you are right, XD.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doc link
https://flyte--4257.org.readthedocs.build/en/4257/community/contribute.html
Tracking issue
#4188
Describe your changes
Check all the applicable boxes
Screenshots
Note to reviewers
@Yicheng-Lu-llll, @samhita-alla, @pingsutw please take a look, thanks a lot!