Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Housekeeping] Flyte and Flytekit both of there pull request template should add more sections. #4366

Closed
2 tasks done
Future-Outlier opened this issue Nov 6, 2023 · 0 comments
Closed
2 tasks done

[Housekeeping] Flyte and Flytekit both of there pull request template should add more sections. #4366

Future-Outlier opened this issue Nov 6, 2023 · 0 comments
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free

Comments

@Future-Outlier
Copy link
Member

Future-Outlier commented Nov 6, 2023 •
edited
Loading

Describe the issue

By including more details in a PR, we can reduce the amount of bugs and make the review process far more comfortable and easier for maintainers.
For example, you can add Docs link section in the PR like this.
#4257

Here's one more example, you can add Setup Process section in the PR like this.
flyteorg/flytekit#1870

What if we do not do this?

We will unable to get the benefits above.

Related component(s)

  • Flytekit
  • Flyte mono repo

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@Future-Outlier Future-Outlier added the housekeeping Issues that help maintain flyte and keep it tech-debt free label Nov 6, 2023
This was referenced Nov 6, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Future-Outlier