Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Replace dependency on lyft/api (kubernetes) #742

Closed
kumare3 opened this issue Feb 17, 2021 · 1 comment
Closed

[BUG] Replace dependency on lyft/api (kubernetes) #742

kumare3 opened this issue Feb 17, 2021 · 1 comment
Assignees
@katrogan
Labels
bug Something isn't working pri1
Milestone
0.12.0

Comments

@kumare3
Copy link
Contributor

kumare3 commented Feb 17, 2021

Describe the bug
Currently to support pod-spec we depend on Lyfts fork of kube api. This is very dangerous and the fork is pretty stale and may break sometime.

Expected behavior
This will need systematic changes all the way down the stack and may break pod plugin. The solution is to use the kubernetes python client for the pod plugin

Order
[ ] fix flytestdlib
[ ] fix flyteidl
[ ] fix flyteplugins
[ ] fix flytepropeller
[ ] fix flyteadmin
[ ] fix flytectl
@kumare3 kumare3 added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers pri1 labels Feb 17, 2021
@kumare3 kumare3 self-assigned this Feb 17, 2021
This was referenced Feb 18, 2021
Merged
Closed
@kumare3 kumare3 removed their assignment Feb 22, 2021
@kumare3 kumare3 removed the untriaged This issues has not yet been looked at by the Maintainers label Feb 22, 2021
@kumare3 kumare3 added this to the 0.12.0 milestone Feb 28, 2021
@kumare3 kumare3 mentioned this issue Feb 28, 2021
Closed
13 tasks
@katrogan katrogan self-assigned this Mar 3, 2021
@katrogan katrogan mentioned this issue Mar 11, 2021
Closed
@kumare3
Copy link
Contributor Author

kumare3 commented Mar 15, 2021

This has now been resolved, will be part of 0.12.0

@kumare3 kumare3 closed this as completed Mar 15, 2021
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@AlekhyaSasi @samhita-alla
Map task updates (flyteorg#742)
53fc67f 
* Updating map task

Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Updating map task

Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Removed map task plugins and added it to flytekit.map_task

Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Updated the AWS batch link

Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Adding default as K8s

Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Update cookbook/core/control_flow/map_task.py

Co-authored-by: Samhita Alla <[email protected]>

Co-authored-by: Samhita Alla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katrogan katrogan

Labels
bug Something isn't working pri1
Projects
None yet
Milestone
0.12.0
Development

No branches or pull requests
2 participants
@katrogan @kumare3