Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core Feature] PodSpec tasks without proto-defined custom #816

Closed
katrogan opened this issue Mar 11, 2021 · 0 comments
Closed

[Core Feature] PodSpec tasks without proto-defined custom #816

katrogan opened this issue Mar 11, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request flytekit FlyteKit Python related issue plugins Plugins related labels (backend or frontend)
Milestone

Comments

@katrogan
Copy link
Contributor

katrogan commented Mar 11, 2021

Motivation: Why do you think this is important?

After #742 it would be good to move to another PodSpec definition for pod type tasks. We can use python k8s client to configure PodSpecs created using the OpenAPI spec, marshal that to a json dict and store that in the task custom.

However, we need to know the name of the primary container for plugin handler to monitor over the task execution lifecycle. To store this primary container name this change would require adding a "meta" type custom field.

Goal: What should the final outcome look like, ideally?

Pod tasks should be completely revamped and serve as a working template for tasks with non-proto defined custom fields.

Describe alternatives you've considered

The current pod spec implementation. This is no longer fully functional because quantity specification is now unsupported with the move to official k8s libraries.

[Optional] Propose: Link/Inline OR Additional context

If you have ideas about the implementation please propose the change. If inline keep it short, if larger then you link to an external document.

@katrogan katrogan added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers flytekit FlyteKit Python related issue plugins Plugins related labels (backend or frontend) and removed untriaged This issues has not yet been looked at by the Maintainers labels Mar 11, 2021
@katrogan katrogan self-assigned this Mar 11, 2021
@katrogan katrogan added this to the 0.12.0 milestone Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request flytekit FlyteKit Python related issue plugins Plugins related labels (backend or frontend)
Projects
None yet
Development

No branches or pull requests

1 participant