Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] FlyteAdmin should validate launch plan labels are k8s compliant #624

Closed
1 of 20 tasks
katrogan opened this issue Nov 20, 2020 · 0 comments
Closed
1 of 20 tasks

[BUG] FlyteAdmin should validate launch plan labels are k8s compliant #624

katrogan opened this issue Nov 20, 2020 · 0 comments
Assignees
@pingsutw
Labels
bug Something isn't working
Milestone
0.18.0

Comments

@katrogan
Copy link
Contributor

Describe the bug
Launch plan labels come from user-provided input values and should be validated.

Expected behavior
Invalid launch plans should be caught at the create execution handler in flyteadfmin

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

To Reproduce
Steps to reproduce the behavior:

  1. ...
  2. ...

Screenshots
If applicable, add screenshots to help explain your problem.

Environment
Flyte component

  • Sandbox (local or on one machine)
  • Cloud hosted
    • AWS
    • GCP
    • Azure
  • Baremetal
  • Other

Additional context
Already done for project labels #551
@katrogan katrogan added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Nov 20, 2020
@kumare3 kumare3 removed the untriaged This issues has not yet been looked at by the Maintainers label Mar 1, 2021
@kumare3 kumare3 added this to the 0.13.0 milestone Mar 1, 2021
@kumare3 kumare3 modified the milestones: 0.13.0, 0.15.0 May 5, 2021
@katrogan katrogan modified the milestones: 0.15.0, 0.16.0 Jul 7, 2021
@EngHabu EngHabu modified the milestones: 0.16.0, 0.17.0 Aug 2, 2021
@EngHabu EngHabu modified the milestones: 0.17.0, 0.18.0 Aug 31, 2021
@pingsutw pingsutw self-assigned this Sep 9, 2021
@pingsutw pingsutw mentioned this issue Sep 9, 2021
Merged
8 tasks
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@flyte-bot
Update Flyteidl version (flyteorg#624)
7904c84 
Signed-off-by: Flyte-Bot <[email protected]>

Signed-off-by: Flyte-Bot <[email protected]>
Co-authored-by: flyte-bot <[email protected]>
eapolinario pushed a commit that referenced this issue Oct 2, 2023
@hamersaw
reverting to parallelism increases only on non-terminal phase updates (…
bb053a7 
…#624)

Signed-off-by: Daniel Rammer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pingsutw pingsutw

Labels
bug Something isn't working
Projects
None yet
Milestone
0.18.0
Development

No branches or pull requests
5 participants
@EngHabu @eapolinario @katrogan @kumare3 @pingsutw