Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Project labels should be k8s compliant #551

Closed
3 of 20 tasks
katrogan opened this issue Oct 13, 2020 · 0 comments
Closed
3 of 20 tasks

[BUG] Project labels should be k8s compliant #551

katrogan opened this issue Oct 13, 2020 · 0 comments
Assignees
@kosigz-lyft
Labels
bug Something isn't working
Milestone
0.9.0

Comments

@katrogan
Copy link
Contributor

Describe the bug
Currently flyteadmin accepts project labels without any validation. When these labels are attached to individual workflow executions the executions may fail.

We already validate project ids here: https://github.com/lyft/flyteadmin/blob/master/pkg/manager/impl/validation/project_validator.go#L27. We should check to make sure project labels are similarly DNS 1123Label compliant

Expected behavior
Flyteadmin should validate that any project create OR update requests include compliant labels.

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

To Reproduce

Screenshots

Environment
Flyte component

  • Sandbox (local or on one machine)
  • Cloud hosted
    • AWS
    • GCP
    • Azure
  • Baremetal
  • Other

Additional context
Add any other context about the problem here.
@katrogan katrogan added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Oct 13, 2020
@katrogan katrogan removed the untriaged This issues has not yet been looked at by the Maintainers label Oct 13, 2020
@kosigz-lyft kosigz-lyft mentioned this issue Oct 14, 2020
Merged
8 tasks
@kumare3 kumare3 added this to the 0.9.0 milestone Oct 15, 2020
@EngHabu EngHabu closed this as completed Nov 4, 2020
@katrogan katrogan mentioned this issue Nov 20, 2020
Closed
20 tasks
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@cosmicBboy
Update sql-alchemy.py (flyteorg#551)
16433da
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Jul 24, 2023
@hamersaw
returning 'Undefined' when recovering a SKIPPED node so that the node…
7abdcd7 
… is executed (flyteorg#551)

Signed-off-by: Daniel Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Jul 24, 2023
@EngHabu
Enrich TerminateExecution error to tell propeller the execution alrea…
1026231 
…dy terminated (flyteorg#551)

* Enrich TerminateWorkflow error to tell propeller the execution already terminated

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Fix unit test

Signed-off-by: Haytham Abuelfutuh <[email protected]>

---------

Signed-off-by: Haytham Abuelfutuh <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
@hamersaw
returning 'Undefined' when recovering a SKIPPED node so that the node…
109bfe7 
… is executed (flyteorg#551)

Signed-off-by: Daniel Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@EngHabu
Enrich TerminateExecution error to tell propeller the execution alrea…
7773fc8 
…dy terminated (flyteorg#551)

* Enrich TerminateWorkflow error to tell propeller the execution already terminated

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Fix unit test

Signed-off-by: Haytham Abuelfutuh <[email protected]>

---------

Signed-off-by: Haytham Abuelfutuh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kosigz-lyft kosigz-lyft

Labels
bug Something isn't working
Projects
None yet
Milestone
0.9.0
Development

No branches or pull requests
4 participants
@EngHabu @katrogan @kumare3 @kosigz-lyft