Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Set launch plan active should accept a named entity rather than identifier #506

Open
3 of 13 tasks
katrogan opened this issue Sep 10, 2020 · 3 comments
Open
3 of 13 tasks

[Feature] Set launch plan active should accept a named entity rather than identifier #506

katrogan opened this issue Sep 10, 2020 · 3 comments
Assignees
@katrogan
Labels
enhancement New feature or request stale

Comments

@katrogan
Copy link
Contributor

Motivation: Why do you think this is important?
As of now, the only field that can change in a LaunchPlanUpdateRequest is the launch plan state. At most one launch plan named entity, that is launch plans sharing a project, domain and name can ever be made active. Therefore, deactivating a launch plan is to set all launch plans for a named entity inactive.

Goal: What should the final outcome look like, ideally?
It should be possible to disable a launch plan without specifying the version.

In the same vein, it could make sense to specify the latest launch plan version by also updating a launch plan by named entity identifier without a version.

Describe alternatives you've considered
The current approach where a full identifier is required.

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

[Optional] Propose: Link/Inline
If you have ideas about the implementation please propose the change. If inline keep it short, if larger then you link to an external document.

Additional context
Add any other context or screenshots about the feature request here.

Is this a blocker for you to adopt Flyte
Please let us know if this makes it impossible to adopt Flyte
@katrogan katrogan added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Sep 10, 2020
@katrogan katrogan self-assigned this Sep 10, 2020
@katrogan katrogan removed the untriaged This issues has not yet been looked at by the Maintainers label Sep 10, 2020
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@hamersaw
check deck uri exists before checking for datastore existance (flyteo…
6de8831 
…rg#506)

Signed-off-by: Dan Rammer <[email protected]>

Signed-off-by: Dan Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@ursucarina
Fixed undefined task input types access in NodeExecutionActions (flyt…
7e44dca 
…eorg#538)

* Fixed undefined task input types access in NodeExecutionActions
Issue occurred due to race condition while loading data, indentical fix applies as for flyteorg#506

Signed-off-by: Nick Müller <[email protected]>

* fix: cannot read properties of undefined (flyteorg#506)

fix: nullref

Signed-off-by: Carina Ursu <[email protected]>

Co-authored-by: Carina Ursu <[email protected]>
(cherry picked from commit d38b98b2d68700415224ad6c621d79e928fded01)

Signed-off-by: Nick Müller <[email protected]>

Co-authored-by: Carina Ursu <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Jul 24, 2023
@wild-endeavor
Add SignalService http handler (flyteorg#506)
ec5528d 
Signed-off-by: Yee Hing Tong <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
@hamersaw
check deck uri exists before checking for datastore existance (flyteo…
ca7c744 
…rg#506)

Signed-off-by: Dan Rammer <[email protected]>

Signed-off-by: Dan Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@wild-endeavor
Add SignalService http handler (flyteorg#506)
f052a5a 
Signed-off-by: Yee Hing Tong <[email protected]>
@github-actions
Copy link

Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Aug 26, 2023
@github-actions
Copy link

github-actions bot commented Sep 2, 2023

Hello 👋, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 2, 2023
@eapolinario eapolinario reopened this Nov 2, 2023
@github-actions github-actions bot removed the stale label Nov 3, 2023
@github-actions GitHub Actions
Copy link

Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable.
Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katrogan katrogan

Labels
enhancement New feature or request stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eapolinario @katrogan