check deck uri exists before checking for datastore existance (flyteo…

…rg#506) Signed-off-by: Dan Rammer <[email protected]> Signed-off-by: Dan Rammer <[email protected]>
eapolinario · Nov 30, 2022 · ca7c744 · ca7c744
1 parent 19acf71
commit ca7c744
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/flytepropeller/pkg/controller/nodes/executor.go b/flytepropeller/pkg/controller/nodes/executor.go
@@ -264,14 +264,16 @@ func (c *nodeExecutor) attemptRecovery(ctx context.Context, nCtx handler.NodeExe
 	}
 
 	deckFile := storage.DataReference(recovered.Closure.GetDeckUri())
-	metadata, err := nCtx.DataStore().Head(ctx, deckFile)
-	if err != nil {
-		logger.Errorf(ctx, "Failed to check the existence of deck file. Error: %v", err)
-		return handler.PhaseInfoUndefined, errors.Wrapf(errors.CausedByError, nCtx.NodeID(), err, "Failed to check the existence of deck file.")
-	}
+	if len(deckFile) > 0 {
+		metadata, err := nCtx.DataStore().Head(ctx, deckFile)
+		if err != nil {
+			logger.Errorf(ctx, "Failed to check the existence of deck file. Error: %v", err)
+			return handler.PhaseInfoUndefined, errors.Wrapf(errors.CausedByError, nCtx.NodeID(), err, "Failed to check the existence of deck file.")
+		}
 
-	if metadata.Exists() {
-		oi.DeckURI = &deckFile
+		if metadata.Exists() {
+			oi.DeckURI = &deckFile
+		}
 	}
 
 	if err := c.store.WriteProtobuf(ctx, outputFile, so, outputs); err != nil {