Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Spot/interruptible docs imply retries come from the user retry budget #3956

Closed
2 tasks done
Tracked by #5783
andrewwdye opened this issue Aug 14, 2023 · 8 comments
Closed
2 tasks done
Tracked by #5783
Assignees
Labels
documentation Improvements or additions to documentation hacktoberfest

Comments

@andrewwdye
Copy link
Contributor

Description

In the spot/interruptible docs we have the following note

If you set retries=n, for instance, and the task gets preempted repeatedly, Flyte will retry on a preemptible/spot instance n-1 times and for the last attempt will retry your task on a non-spot (regular) instance. Please note that tasks will only be retried if at least one retry is allowed using the retries parameter in the task decorator.

This implies that interruptible retries come from the user-specified user error retry budget. However, in practice spot interruptions are taken from the system retry budget.

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@andrewwdye andrewwdye added documentation Improvements or additions to documentation untriaged This issues has not yet been looked at by the Maintainers labels Aug 14, 2023
@eapolinario eapolinario removed the untriaged This issues has not yet been looked at by the Maintainers label Aug 18, 2023
Copy link

Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable.
Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label May 15, 2024
@davidmirror-ops
Copy link
Contributor

Keep it open

@RaghavMangla
Copy link
Contributor

Hi! I would like to work on this issue

@davidmirror-ops
Copy link
Contributor

@RaghavMangla thanks for your willingness to contribute. Considering you already have 6 issues assigned to you, and following the principle of "first come first serve" we'd like to encourage you to send PRs for the issues where you are already an assignee and then, if no one has taken this one, we can assign to you. Thanks in advance :)

@RaghavMangla
Copy link
Contributor

RaghavMangla commented Oct 5, 2024 via email

@RaghavMangla

This comment was marked as off-topic.

@ap0calypse8
Copy link
Contributor

i want to work on this issue

@davidmirror-ops
Copy link
Contributor

@ap0calypse8 thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation hacktoberfest
Projects
None yet
Development

No branches or pull requests

5 participants