Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide ability to set a max limit on number of executors that can be set by user. #366

Closed
1 of 13 tasks
migueltol22 opened this issue Jun 25, 2020 · 4 comments
Closed
1 of 13 tasks
Assignees
Labels
enhancement New feature or request stale untriaged This issues has not yet been looked at by the Maintainers

Comments

@migueltol22
Copy link
Contributor

Motivation: Why do you think this is important?
A user can specify an arbitrarily high number of executors in spark task. From the maintainer perspective it should be possible to add safeguards to avoid a user setting a very large number of executors.

Goal: What should the final outcome look like, ideally?
Configuration option to specify max limit of executors in spark plugin.

Describe alternatives you've considered

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

[Optional] Propose: Link/Inline
If you have ideas about the implementation please propose the change. If inline keep it short, if larger then you link to an external document.

Additional context
Add any other context or screenshots about the feature request here.

Is this a blocker for you to adopt Flyte
Please let us know if this makes it impossible to adopt Flyte

@migueltol22 migueltol22 added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Jun 25, 2020
@migueltol22 migueltol22 self-assigned this Jun 25, 2020
@kumare3
Copy link
Contributor

kumare3 commented Feb 16, 2021

@migueltol22 it seems you have a PR in progress here, any updates?

eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
…teorg#366)

* checkpoint

Signed-off-by: Katrina Rogan <[email protected]>

* Add test

Signed-off-by: Katrina Rogan <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Jul 24, 2023
* Switch to using official `dask` plugin

Signed-off-by: Bernhard Stadlbauer <[email protected]>

* Fix small code nits

Signed-off-by: Bernhard Stadlbauer <[email protected]>

---------

Signed-off-by: Bernhard Stadlbauer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
…teorg#366)

* checkpoint

Signed-off-by: Katrina Rogan <[email protected]>

* Add test

Signed-off-by: Katrina Rogan <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
* Switch to using official `dask` plugin

Signed-off-by: Bernhard Stadlbauer <[email protected]>

* Fix small code nits

Signed-off-by: Bernhard Stadlbauer <[email protected]>

---------

Signed-off-by: Bernhard Stadlbauer <[email protected]>
@github-actions
Copy link

Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Aug 26, 2023
@github-actions
Copy link

github-actions bot commented Sep 2, 2023

Hello 👋, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 2, 2023
@eapolinario eapolinario reopened this Nov 2, 2023
@hamersaw
Copy link
Contributor

hamersaw commented Dec 5, 2023

closing as unplanned.

@hamersaw hamersaw closed this as completed Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale untriaged This issues has not yet been looked at by the Maintainers
Projects
None yet
Development

No branches or pull requests

4 participants