Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console sends undefined instead of false for unchecked toggle switches #18

Closed
georgesnelling opened this issue Nov 19, 2019 · 0 comments · Fixed by flyteorg/flyteconsole#34
Assignees
Labels
bug Something isn't working pri2 ui Admin console user interface
Milestone

Comments

@georgesnelling
Copy link
Contributor

For workflows which take boolean values, the Console renders a toggle switch. When the toggle remains switched to "off", the resulting computed value is undefined instead of false. This translated to passing no value for the input when making the launch request.
For required inputs with no default value, that will result in a 400.

At the very least, if a boolean value is required and has no default, we should be translating an unchecked toggle to false to make sure the launch request succeeds.

Once default values are implemented for the form, this should become less of an issue.

@georgesnelling georgesnelling added bug Something isn't working Compliance pri2 labels Nov 19, 2019
@schottra schottra added the ui Admin console user interface label Dec 11, 2019
@kumare3 kumare3 added this to the 0.2.0 milestone Mar 30, 2020
eapolinario referenced this issue in eapolinario/flyte Dec 6, 2022
* add namepace configuration

* add namespace files

* remove unused var

* update propeller executor config

* use propeller executor configuration

* to lowercase

* fix conflicts

* update namespace test

* remove namespaceMapping variable

* fix compile issues

* add project-domain option and remove incorrect log messages

* upd mock configuration provider

* update unit tests

* Merge logs on task execution event updates (#18)

* use fallthrough

* Correct Lint Errors and Add Documentation on Pre-Commit (#19)

* README update

* Fix lint errors

* add namepace configuration

* add namespace files

* remove unused var

* update propeller executor config

* use propeller executor configuration

* to lowercase

* fix conflicts

* update namespace test

* remove namespaceMapping variable

* fix compile issues

* add project-domain option and remove incorrect log messages

* upd mock configuration provider

* update unit tests

* use fallthrough

* fix conflicts

* fix more conflicts

* lint

* remove duplicate package

* fix lint errors
eapolinario referenced this issue in eapolinario/flyte Dec 20, 2022
this extension is required for `datasets` because of UUID.
eapolinario referenced this issue in eapolinario/flyte Aug 21, 2023
* add namepace configuration

* add namespace files

* remove unused var

* update propeller executor config

* use propeller executor configuration

* to lowercase

* fix conflicts

* update namespace test

* remove namespaceMapping variable

* fix compile issues

* add project-domain option and remove incorrect log messages

* upd mock configuration provider

* update unit tests

* Merge logs on task execution event updates (#18)

* use fallthrough

* Correct Lint Errors and Add Documentation on Pre-Commit (#19)

* README update

* Fix lint errors

* add namepace configuration

* add namespace files

* remove unused var

* update propeller executor config

* use propeller executor configuration

* to lowercase

* fix conflicts

* update namespace test

* remove namespaceMapping variable

* fix compile issues

* add project-domain option and remove incorrect log messages

* upd mock configuration provider

* update unit tests

* use fallthrough

* fix conflicts

* fix more conflicts

* lint

* remove duplicate package

* fix lint errors
eapolinario referenced this issue in eapolinario/flyte Aug 21, 2023
this extension is required for `datasets` because of UUID.
eapolinario referenced this issue in eapolinario/flyte Aug 21, 2023
* Welcome Bot Message

Signed-off-by: samhita-alla <[email protected]>

* Modified update.sh -- in sync with flyteorg/boilerplate repo

Signed-off-by: samhita-alla <[email protected]>

* Added .gitignore file

Signed-off-by: samhita-alla <[email protected]>

* Modified .gitignore file

Signed-off-by: samhita-alla <[email protected]>

* Modified the PR message

Signed-off-by: samhita-alla <[email protected]>

* Modified the PR message

Signed-off-by: samhita-alla <[email protected]>

* Update Boilerplate

Signed-off-by: Samhita Alla <[email protected]>

* Updated permissions of update.sh file

Signed-off-by: Samhita Alla <[email protected]>

* Updated update.sh

Signed-off-by: Samhita Alla <[email protected]>

* Modified config.yml path in update.sh

Signed-off-by: Samhita Alla <[email protected]>
eapolinario referenced this issue in eapolinario/flyte Sep 26, 2023
this extension is required for `datasets` because of UUID.
eapolinario pushed a commit that referenced this issue Apr 30, 2024
* addendums

* Update README.md
austin362667 pushed a commit to austin362667/flyte that referenced this issue May 7, 2024
* addendums

* Update README.md
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this issue Jul 2, 2024
* addendums

* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pri2 ui Admin console user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants