Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add flyte-core missing webhook priorityClassName
Browse files Browse the repository at this point in the history
 - All the other pods can have their priorityClassName set except for
   the webhook

Signed-off-by: ddl-ebrown <ethan.brown@dominodatalab.com>
ddl-ebrown committed Mar 15, 2024
1 parent 3100c12 commit 76a414f
Showing 6 changed files with 12 additions and 6 deletions.
1 change: 1 addition & 0 deletions charts/flyte-core/README.md
Original file line number Diff line number Diff line change
@@ -290,6 +290,7 @@ helm install gateway bitnami/contour -n flyte
| storage.s3.secretKey | string | `""` | AWS IAM user secret access key to use for S3 bucket auth, only used if authType is set to accesskey |
| storage.type | string | `"sandbox"` | Sets the storage type. Supported values are sandbox, s3, gcs and custom. |
| webhook.enabled | bool | `true` | enable or disable secrets webhook |
| webhook.priorityClassName | string | `""` | Sets priorityClassName for webhook pod |
| webhook.resources.requests.cpu | string | `"200m"` | |
| webhook.resources.requests.ephemeral-storage | string | `"500Mi"` | |
| webhook.resources.requests.memory | string | `"500Mi"` | |
3 changes: 3 additions & 0 deletions charts/flyte-core/templates/propeller/webhook.yaml
Original file line number Diff line number Diff line change
@@ -39,6 +39,9 @@ spec:
securityContext: {{ tpl (toYaml .) $ | nindent 8 }}
{{- end }}
serviceAccountName: {{ template "flyte-pod-webhook.name" . }}
{{- if .Values.webhook.priorityClassName }}
priorityClassName: {{ .Values.webhook.priorityClassName }}
{{- end }}
{{- if .Values.webhook.enabled }}
initContainers:
- name: generate-secrets
2 changes: 2 additions & 0 deletions charts/flyte-core/values.yaml
Original file line number Diff line number Diff line change
@@ -444,6 +444,8 @@ secrets:
webhook:
# -- enable or disable secrets webhook
enabled: true
# -- Sets priorityClassName for webhook pod
priorityClassName: ""
# -- Configuration for service accounts for the webhook
serviceAccount:
# -- Should a service account be created for the webhook
4 changes: 2 additions & 2 deletions docker/sandbox-bundled/manifests/complete-agent.yaml
Original file line number Diff line number Diff line change
@@ -816,7 +816,7 @@ type: Opaque
---
apiVersion: v1
data:
haSharedSecret: VTg5RFBvY205cXRtcEVFbw==
haSharedSecret: cUY0OVJwT2thb0JiNUprUw==
proxyPassword: ""
proxyUsername: ""
kind: Secret
@@ -1412,7 +1412,7 @@ spec:
metadata:
annotations:
checksum/config: 8f50e768255a87f078ba8b9879a0c174c3e045ffb46ac8723d2eedbe293c8d81
checksum/secret: b8339a7b42c1e04b994b517d4ddd749074787df4a0eaef9e1aa2181988aea2d7
checksum/secret: aa6814e56b6e235d17878f5cff154dc2d04b685866406957dff586b3347f2107
labels:
app: docker-registry
release: flyte-sandbox
4 changes: 2 additions & 2 deletions docker/sandbox-bundled/manifests/complete.yaml
Original file line number Diff line number Diff line change
@@ -796,7 +796,7 @@ type: Opaque
---
apiVersion: v1
data:
haSharedSecret: ZTNEUmhqY1VsWDBXNFowTg==
haSharedSecret: SEdTZDYzWE80SWUxUWkwaw==
proxyPassword: ""
proxyUsername: ""
kind: Secret
@@ -1360,7 +1360,7 @@ spec:
metadata:
annotations:
checksum/config: 8f50e768255a87f078ba8b9879a0c174c3e045ffb46ac8723d2eedbe293c8d81
checksum/secret: cedf489b22e27428631c5c365e58bfd51cf8465bf04d07a74462677278017b80
checksum/secret: 4716ab50ab0d50d5d70ea8081f241a2bf0d71b279534afa82db756fd59b42ed9
labels:
app: docker-registry
release: flyte-sandbox
4 changes: 2 additions & 2 deletions docker/sandbox-bundled/manifests/dev.yaml
Original file line number Diff line number Diff line change
@@ -499,7 +499,7 @@ metadata:
---
apiVersion: v1
data:
haSharedSecret: bkV2U2JzN0o2TXNVcHJTMg==
haSharedSecret: Wk0wR3pRVU4yemU5cXpHMQ==
proxyPassword: ""
proxyUsername: ""
kind: Secret
@@ -934,7 +934,7 @@ spec:
metadata:
annotations:
checksum/config: 8f50e768255a87f078ba8b9879a0c174c3e045ffb46ac8723d2eedbe293c8d81
checksum/secret: 2f2e4b3f4abc8a670a75900bd0c7987fb3afa6b2a287fdf7292fbeb755c00c12
checksum/secret: c94cf5881eac2d4c8424b8a583e9beb16073bf72764d9d8531114d4d80499bbf
labels:
app: docker-registry
release: flyte-sandbox

0 comments on commit 76a414f

Please sign in to comment.