Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Update code of conduct #46

Merged
merged 1 commit into from
Jul 29, 2021
Merged

Conversation

samhita-alla
Copy link
Contributor

Signed-off-by: Samhita Alla [email protected]

flyteorg/flyte#1252

Read then delete

  • Make sure to use a concise title for the pull-request.
  • Use #patch, #minor or #major in the pull-request title to bump the corresponding version. Otherwise, the patch version
    will be bumped. More details

TL;DR

Please replace this text with a description of what this PR accomplishes.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Signed-off-by: Samhita Alla <[email protected]>
@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #46 (47b657c) into master (c11a05c) will increase coverage by 1.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
+ Coverage   65.84%   67.02%   +1.17%     
==========================================
  Files          28       28              
  Lines         931     1034     +103     
==========================================
+ Hits          613      693      +80     
- Misses        259      282      +23     
  Partials       59       59              
Flag Coverage Δ
unittests 65.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/errors/errors.go 75.00% <0.00%> (-3.58%) ⬇️
pkg/repositories/config/dbconfigsection_flags.go 41.66% <0.00%> (-1.20%) ⬇️
pkg/repositories/transformers/artifact.go 78.87% <0.00%> (-0.50%) ⬇️
pkg/config/config_flags.go 33.33% <0.00%> (ø)
pkg/repositories/factory.go 0.00% <0.00%> (ø)
pkg/repositories/gormimpl/sort.go 100.00% <0.00%> (ø)
pkg/repositories/postgres_repo.go 0.00% <0.00%> (ø)
pkg/repositories/gormimpl/filter.go 100.00% <0.00%> (ø)
pkg/repositories/gormimpl/metrics.go 100.00% <0.00%> (ø)
pkg/repositories/transformers/tag.go 100.00% <0.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c11a05c...47b657c. Read the comment docs.

@kumare3 kumare3 merged commit 5583911 into flyteorg:master Jul 29, 2021
hamersaw pushed a commit to hamersaw/datacatalog that referenced this pull request Sep 28, 2021
Signed-off-by: Ketan Umare <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
hamersaw pushed a commit to hamersaw/datacatalog that referenced this pull request Sep 28, 2021
Signed-off-by: Ketan Umare <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
EngHabu added a commit that referenced this pull request Nov 24, 2021
* WIP: add reservation apis

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* add missing files

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* added create DAO

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* Add get dao

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* wip

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* fix tests

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* wired reservation manager

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* add todos

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* add more tests

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* add more tests

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* add more logging

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* add logging and stats

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* fix lint

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* add more comments

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* First -> Take

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* WIP: add createOrupdate API

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* Added boilerplate automation (#41)

Signed-off-by: Ketan Umare <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* update boilerplate code (#40)

Signed-off-by: Samhita Alla <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* Upgrade gorm to v1.21.9 (#42)

Signed-off-by: Daniel Rammer <[email protected]>

* Added boilerplate automation (#43)

Signed-off-by: Yuvraj <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* add more instructinos

Use upsert

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* add more comments

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* refactor a bit

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* add timer

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* fix lint / tests

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* add comments & tests

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* fix lint

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* add docs

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* Fix connection error handling (#45)

Signed-off-by: Daniel Rammer <[email protected]>

* Update code of conduct (#46)

Signed-off-by: Ketan Umare <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* separated ReservationManager CreateOrUpdate function into individual Create and Update functions

Signed-off-by: Daniel Rammer <[email protected]>

* fixed race condition on Reservation repository Create function

Signed-off-by: Daniel Rammer <[email protected]>

* changed reservation expiration to use heartbeatInterval and heartbeatGracePeriodMultiplier

Signed-off-by: Daniel Rammer <[email protected]>

* fixed lint and unit test errors

Signed-off-by: Daniel Rammer <[email protected]>

* added unit tests for extending reservation and update failure

Signed-off-by: Daniel Rammer <[email protected]>

* removed ExtendReservation API mocks

Signed-off-by: Daniel Rammer <[email protected]>

* added ExpiresAt and HeartbeatInterval fiedls to ReservationStatus return based on new API

Signed-off-by: Daniel Rammer <[email protected]>

* implemented ReleaseReservation

Signed-off-by: Daniel Rammer <[email protected]>

* added unit tests for reservation transformer

Signed-off-by: Daniel Rammer <[email protected]>

* fixed lint errors

Signed-off-by: Daniel Rammer <[email protected]>

* implemented unit tests for ReleaseReservation API call

Signed-off-by: Daniel Rammer <[email protected]>

* updated reservation API to only work with reservations - not actual artifacts.

Signed-off-by: Daniel Rammer <[email protected]>

* Fix error type check to detect uniqueConstraintViolation

Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* Revert "Fix error type check to detect uniqueConstraintViolation"

This reverts commit 2ba0775.

Signed-off-by: Daniel Rammer <[email protected]>

* Fix gorm wrong error type cast (#48)

* Fix gorm wrong error type cast

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Fix unit tests

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Support unwrapping errors to detect connection problems

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* cleanup

Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* added support for heartbeat_interval definition in reservation manager

Signed-off-by: Daniel Rammer <[email protected]>

* updated test and fixed lint errors

Signed-off-by: Daniel Rammer <[email protected]>

* removed unnecessary dependencies from go.mod

Signed-off-by: Daniel Rammer <[email protected]>

* updated flyteidl version - change before merging

Signed-off-by: Daniel Rammer <[email protected]>

* adding reservation model to migration

Signed-off-by: Daniel Rammer <[email protected]>

* udpated dockerfile go template to reflect current master fixing rebase overwrites

Signed-off-by: Daniel Rammer <[email protected]>

* and again .. with a space

Signed-off-by: Daniel Rammer <[email protected]>

* add docs on exports

Signed-off-by: Daniel Rammer <[email protected]>

* changed configuration to use config.Duration from flytestdlib instead of defining on seconds

Signed-off-by: Daniel Rammer <[email protected]>

* added owner id to reservation gorm impl delete function

Signed-off-by: Daniel Rammer <[email protected]>

* if reservation is missing on release reservation (meaning another entity acquired it) then gracefully fail

Signed-off-by: Daniel Rammer <[email protected]>

* updated flyteidl version

Signed-off-by: Daniel Rammer <[email protected]>

* remove flyteidl replace in go.mod and updating to latest version

Signed-off-by: Daniel Rammer <[email protected]>

Co-authored-by: Chao-Han Tsai <[email protected]>
Co-authored-by: Yuvraj <[email protected]>
Co-authored-by: Samhita Alla <[email protected]>
Co-authored-by: Haytham Abuelfutuh <[email protected]>
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
Signed-off-by: Ketan Umare <[email protected]>
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
* WIP: add reservation apis

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* add missing files

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* added create DAO

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* Add get dao

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* wip

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* fix tests

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* wired reservation manager

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* add todos

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* add more tests

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* add more tests

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* add more logging

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* add logging and stats

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* fix lint

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* add more comments

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* First -> Take

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* WIP: add createOrupdate API

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* Added boilerplate automation (#41)

Signed-off-by: Ketan Umare <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* update boilerplate code (#40)

Signed-off-by: Samhita Alla <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* Upgrade gorm to v1.21.9 (#42)

Signed-off-by: Daniel Rammer <[email protected]>

* Added boilerplate automation (#43)

Signed-off-by: Yuvraj <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* add more instructinos

Use upsert

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* add more comments

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* refactor a bit

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* add timer

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* fix lint / tests

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* add comments & tests

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* fix lint

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* add docs

Signed-off-by: Chao-Han Tsai <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* Fix connection error handling (#45)

Signed-off-by: Daniel Rammer <[email protected]>

* Update code of conduct (#46)

Signed-off-by: Ketan Umare <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* separated ReservationManager CreateOrUpdate function into individual Create and Update functions

Signed-off-by: Daniel Rammer <[email protected]>

* fixed race condition on Reservation repository Create function

Signed-off-by: Daniel Rammer <[email protected]>

* changed reservation expiration to use heartbeatInterval and heartbeatGracePeriodMultiplier

Signed-off-by: Daniel Rammer <[email protected]>

* fixed lint and unit test errors

Signed-off-by: Daniel Rammer <[email protected]>

* added unit tests for extending reservation and update failure

Signed-off-by: Daniel Rammer <[email protected]>

* removed ExtendReservation API mocks

Signed-off-by: Daniel Rammer <[email protected]>

* added ExpiresAt and HeartbeatInterval fiedls to ReservationStatus return based on new API

Signed-off-by: Daniel Rammer <[email protected]>

* implemented ReleaseReservation

Signed-off-by: Daniel Rammer <[email protected]>

* added unit tests for reservation transformer

Signed-off-by: Daniel Rammer <[email protected]>

* fixed lint errors

Signed-off-by: Daniel Rammer <[email protected]>

* implemented unit tests for ReleaseReservation API call

Signed-off-by: Daniel Rammer <[email protected]>

* updated reservation API to only work with reservations - not actual artifacts.

Signed-off-by: Daniel Rammer <[email protected]>

* Fix error type check to detect uniqueConstraintViolation

Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* Revert "Fix error type check to detect uniqueConstraintViolation"

This reverts commit 22c2d03.

Signed-off-by: Daniel Rammer <[email protected]>

* Fix gorm wrong error type cast (#48)

* Fix gorm wrong error type cast

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Fix unit tests

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Support unwrapping errors to detect connection problems

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* cleanup

Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>

* added support for heartbeat_interval definition in reservation manager

Signed-off-by: Daniel Rammer <[email protected]>

* updated test and fixed lint errors

Signed-off-by: Daniel Rammer <[email protected]>

* removed unnecessary dependencies from go.mod

Signed-off-by: Daniel Rammer <[email protected]>

* updated flyteidl version - change before merging

Signed-off-by: Daniel Rammer <[email protected]>

* adding reservation model to migration

Signed-off-by: Daniel Rammer <[email protected]>

* udpated dockerfile go template to reflect current master fixing rebase overwrites

Signed-off-by: Daniel Rammer <[email protected]>

* and again .. with a space

Signed-off-by: Daniel Rammer <[email protected]>

* add docs on exports

Signed-off-by: Daniel Rammer <[email protected]>

* changed configuration to use config.Duration from flytestdlib instead of defining on seconds

Signed-off-by: Daniel Rammer <[email protected]>

* added owner id to reservation gorm impl delete function

Signed-off-by: Daniel Rammer <[email protected]>

* if reservation is missing on release reservation (meaning another entity acquired it) then gracefully fail

Signed-off-by: Daniel Rammer <[email protected]>

* updated flyteidl version

Signed-off-by: Daniel Rammer <[email protected]>

* remove flyteidl replace in go.mod and updating to latest version

Signed-off-by: Daniel Rammer <[email protected]>

Co-authored-by: Chao-Han Tsai <[email protected]>
Co-authored-by: Yuvraj <[email protected]>
Co-authored-by: Samhita Alla <[email protected]>
Co-authored-by: Haytham Abuelfutuh <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants