This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Update boilerplate code for Welcome Bot #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Samhita Alla <[email protected]>
pmahindrakar-oss
approved these changes
Apr 30, 2021
kumare3
approved these changes
Apr 30, 2021
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
=======================================
Coverage 64.33% 64.33%
=======================================
Files 28 28
Lines 914 914
=======================================
Hits 588 588
Misses 265 265
Partials 61 61
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
Congrats on merging your first pull request! 🎉 |
hamersaw
pushed a commit
to hamersaw/datacatalog
that referenced
this pull request
Sep 28, 2021
Signed-off-by: Samhita Alla <[email protected]> Signed-off-by: Daniel Rammer <[email protected]>
hamersaw
pushed a commit
to hamersaw/datacatalog
that referenced
this pull request
Sep 28, 2021
Signed-off-by: Samhita Alla <[email protected]> Signed-off-by: Daniel Rammer <[email protected]>
EngHabu
added a commit
that referenced
this pull request
Nov 24, 2021
* WIP: add reservation apis Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add missing files Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * added create DAO Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * Add get dao Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * wip Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * fix tests Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * wired reservation manager Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add todos Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add more tests Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add more tests Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add more logging Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add logging and stats Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * fix lint Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add more comments Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * First -> Take Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * WIP: add createOrupdate API Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * Added boilerplate automation (#41) Signed-off-by: Ketan Umare <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * update boilerplate code (#40) Signed-off-by: Samhita Alla <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * Upgrade gorm to v1.21.9 (#42) Signed-off-by: Daniel Rammer <[email protected]> * Added boilerplate automation (#43) Signed-off-by: Yuvraj <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add more instructinos Use upsert Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add more comments Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * refactor a bit Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add timer Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * fix lint / tests Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add comments & tests Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * fix lint Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add docs Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * Fix connection error handling (#45) Signed-off-by: Daniel Rammer <[email protected]> * Update code of conduct (#46) Signed-off-by: Ketan Umare <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * separated ReservationManager CreateOrUpdate function into individual Create and Update functions Signed-off-by: Daniel Rammer <[email protected]> * fixed race condition on Reservation repository Create function Signed-off-by: Daniel Rammer <[email protected]> * changed reservation expiration to use heartbeatInterval and heartbeatGracePeriodMultiplier Signed-off-by: Daniel Rammer <[email protected]> * fixed lint and unit test errors Signed-off-by: Daniel Rammer <[email protected]> * added unit tests for extending reservation and update failure Signed-off-by: Daniel Rammer <[email protected]> * removed ExtendReservation API mocks Signed-off-by: Daniel Rammer <[email protected]> * added ExpiresAt and HeartbeatInterval fiedls to ReservationStatus return based on new API Signed-off-by: Daniel Rammer <[email protected]> * implemented ReleaseReservation Signed-off-by: Daniel Rammer <[email protected]> * added unit tests for reservation transformer Signed-off-by: Daniel Rammer <[email protected]> * fixed lint errors Signed-off-by: Daniel Rammer <[email protected]> * implemented unit tests for ReleaseReservation API call Signed-off-by: Daniel Rammer <[email protected]> * updated reservation API to only work with reservations - not actual artifacts. Signed-off-by: Daniel Rammer <[email protected]> * Fix error type check to detect uniqueConstraintViolation Signed-off-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * Revert "Fix error type check to detect uniqueConstraintViolation" This reverts commit 2ba0775. Signed-off-by: Daniel Rammer <[email protected]> * Fix gorm wrong error type cast (#48) * Fix gorm wrong error type cast Signed-off-by: Haytham Abuelfutuh <[email protected]> * Fix unit tests Signed-off-by: Haytham Abuelfutuh <[email protected]> * Support unwrapping errors to detect connection problems Signed-off-by: Haytham Abuelfutuh <[email protected]> * cleanup Signed-off-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * added support for heartbeat_interval definition in reservation manager Signed-off-by: Daniel Rammer <[email protected]> * updated test and fixed lint errors Signed-off-by: Daniel Rammer <[email protected]> * removed unnecessary dependencies from go.mod Signed-off-by: Daniel Rammer <[email protected]> * updated flyteidl version - change before merging Signed-off-by: Daniel Rammer <[email protected]> * adding reservation model to migration Signed-off-by: Daniel Rammer <[email protected]> * udpated dockerfile go template to reflect current master fixing rebase overwrites Signed-off-by: Daniel Rammer <[email protected]> * and again .. with a space Signed-off-by: Daniel Rammer <[email protected]> * add docs on exports Signed-off-by: Daniel Rammer <[email protected]> * changed configuration to use config.Duration from flytestdlib instead of defining on seconds Signed-off-by: Daniel Rammer <[email protected]> * added owner id to reservation gorm impl delete function Signed-off-by: Daniel Rammer <[email protected]> * if reservation is missing on release reservation (meaning another entity acquired it) then gracefully fail Signed-off-by: Daniel Rammer <[email protected]> * updated flyteidl version Signed-off-by: Daniel Rammer <[email protected]> * remove flyteidl replace in go.mod and updating to latest version Signed-off-by: Daniel Rammer <[email protected]> Co-authored-by: Chao-Han Tsai <[email protected]> Co-authored-by: Yuvraj <[email protected]> Co-authored-by: Samhita Alla <[email protected]> Co-authored-by: Haytham Abuelfutuh <[email protected]>
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
Signed-off-by: Samhita Alla <[email protected]>
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* WIP: add reservation apis Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add missing files Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * added create DAO Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * Add get dao Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * wip Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * fix tests Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * wired reservation manager Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add todos Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add more tests Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add more tests Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add more logging Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add logging and stats Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * fix lint Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add more comments Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * First -> Take Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * WIP: add createOrupdate API Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * Added boilerplate automation (#41) Signed-off-by: Ketan Umare <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * update boilerplate code (#40) Signed-off-by: Samhita Alla <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * Upgrade gorm to v1.21.9 (#42) Signed-off-by: Daniel Rammer <[email protected]> * Added boilerplate automation (#43) Signed-off-by: Yuvraj <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add more instructinos Use upsert Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add more comments Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * refactor a bit Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add timer Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * fix lint / tests Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add comments & tests Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * fix lint Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add docs Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * Fix connection error handling (#45) Signed-off-by: Daniel Rammer <[email protected]> * Update code of conduct (#46) Signed-off-by: Ketan Umare <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * separated ReservationManager CreateOrUpdate function into individual Create and Update functions Signed-off-by: Daniel Rammer <[email protected]> * fixed race condition on Reservation repository Create function Signed-off-by: Daniel Rammer <[email protected]> * changed reservation expiration to use heartbeatInterval and heartbeatGracePeriodMultiplier Signed-off-by: Daniel Rammer <[email protected]> * fixed lint and unit test errors Signed-off-by: Daniel Rammer <[email protected]> * added unit tests for extending reservation and update failure Signed-off-by: Daniel Rammer <[email protected]> * removed ExtendReservation API mocks Signed-off-by: Daniel Rammer <[email protected]> * added ExpiresAt and HeartbeatInterval fiedls to ReservationStatus return based on new API Signed-off-by: Daniel Rammer <[email protected]> * implemented ReleaseReservation Signed-off-by: Daniel Rammer <[email protected]> * added unit tests for reservation transformer Signed-off-by: Daniel Rammer <[email protected]> * fixed lint errors Signed-off-by: Daniel Rammer <[email protected]> * implemented unit tests for ReleaseReservation API call Signed-off-by: Daniel Rammer <[email protected]> * updated reservation API to only work with reservations - not actual artifacts. Signed-off-by: Daniel Rammer <[email protected]> * Fix error type check to detect uniqueConstraintViolation Signed-off-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * Revert "Fix error type check to detect uniqueConstraintViolation" This reverts commit 22c2d03. Signed-off-by: Daniel Rammer <[email protected]> * Fix gorm wrong error type cast (#48) * Fix gorm wrong error type cast Signed-off-by: Haytham Abuelfutuh <[email protected]> * Fix unit tests Signed-off-by: Haytham Abuelfutuh <[email protected]> * Support unwrapping errors to detect connection problems Signed-off-by: Haytham Abuelfutuh <[email protected]> * cleanup Signed-off-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * added support for heartbeat_interval definition in reservation manager Signed-off-by: Daniel Rammer <[email protected]> * updated test and fixed lint errors Signed-off-by: Daniel Rammer <[email protected]> * removed unnecessary dependencies from go.mod Signed-off-by: Daniel Rammer <[email protected]> * updated flyteidl version - change before merging Signed-off-by: Daniel Rammer <[email protected]> * adding reservation model to migration Signed-off-by: Daniel Rammer <[email protected]> * udpated dockerfile go template to reflect current master fixing rebase overwrites Signed-off-by: Daniel Rammer <[email protected]> * and again .. with a space Signed-off-by: Daniel Rammer <[email protected]> * add docs on exports Signed-off-by: Daniel Rammer <[email protected]> * changed configuration to use config.Duration from flytestdlib instead of defining on seconds Signed-off-by: Daniel Rammer <[email protected]> * added owner id to reservation gorm impl delete function Signed-off-by: Daniel Rammer <[email protected]> * if reservation is missing on release reservation (meaning another entity acquired it) then gracefully fail Signed-off-by: Daniel Rammer <[email protected]> * updated flyteidl version Signed-off-by: Daniel Rammer <[email protected]> * remove flyteidl replace in go.mod and updating to latest version Signed-off-by: Daniel Rammer <[email protected]> Co-authored-by: Chao-Han Tsai <[email protected]> Co-authored-by: Yuvraj <[email protected]> Co-authored-by: Samhita Alla <[email protected]> Co-authored-by: Haytham Abuelfutuh <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Samhita Alla [email protected]
TL;DR
Update boilerplate.
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/lyft/flyte/issues/
Follow-up issue
NA
OR
https://github.com/lyft/flyte/issues/