Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh 261 logging sampler #530

Closed
wants to merge 2 commits into from
Closed

Conversation

seunghyupoh3517
Copy link
Contributor

@seunghyupoh3517 seunghyupoh3517 commented Sep 19, 2022

Checklist
  • Tested in playground or other setup
  • Documentation is changed or added
  • Tests and/or benchmarks are included
  • Breaking changes

Description of change

  • Introducing LevelSampler of each level is set with BurstSampler (Debug, Info, Warn, Error, Trace)

This change is Reviewable

@seunghyupoh3517 seunghyupoh3517 self-assigned this Sep 19, 2022
@seunghyupoh3517 seunghyupoh3517 requested a review from a team as a code owner September 19, 2022 17:31
@seunghyupoh3517 seunghyupoh3517 linked an issue Sep 19, 2022 that may be closed by this pull request
@seunghyupoh3517
Copy link
Contributor Author

LevelSampler+BurstSampler introduce more granular control with separate BurstSampler config for each log level, prevents the log flood - appropriate configuration for each level (Debug, Info, Warn, Error, TraceSampler) should be applied.

@seunghyupoh3517 seunghyupoh3517 marked this pull request as draft September 19, 2022 17:36
@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Base: 49.94% // Head: 49.83% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (3244705) compared to base (a075dbe).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #530      +/-   ##
==========================================
- Coverage   49.94%   49.83%   -0.11%     
==========================================
  Files         259      259              
  Lines       19546    19591      +45     
==========================================
+ Hits         9762     9763       +1     
- Misses       9156     9200      +44     
  Partials      628      628              
Impacted Files Coverage Δ
pkg/log/log.go 34.84% <0.00%> (-7.17%) ⬇️
...taplane/resources/classifier/extractors/compile.go 79.14% <0.00%> (+0.61%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@seunghyupoh3517 seunghyupoh3517 deleted the GH-261-logging-sampler branch September 30, 2022 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add logging sampler
1 participant