Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging sampler #261

Closed
kwapik opened this issue Aug 31, 2022 · 1 comment
Closed

Add logging sampler #261

kwapik opened this issue Aug 31, 2022 · 1 comment
Assignees
@seunghyupoh3517
Labels
enhancement New feature or request

Comments

@kwapik
Copy link
Contributor

kwapik commented Aug 31, 2022

To prevent log flood, like one fixed in #260, some log sampling needs to be introduced.

BurstSampler should be introduced to the platform logger, with appropriate config. See https://pkg.go.dev/github.com/rs/zerolog#section-readme
@jaidesai-fn jaidesai-fn added enhancement New feature or request and removed C-Platform labels Sep 5, 2022
@seunghyupoh3517 seunghyupoh3517 linked a pull request Sep 19, 2022 that will close this issue
Gh 261 logging sampler #530
Closed
4 tasks
@seunghyupoh3517
Copy link
Contributor

We already have sampled logger functions in the platform logger and can customize the sampler for the log samplings.

@seunghyupoh3517 seunghyupoh3517 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seunghyupoh3517 seunghyupoh3517

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Gh 261 logging sampler fluxninja/aperture
3 participants
@kwapik @seunghyupoh3517 @jaidesai-fn