Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Agent Group processor to FN pipeline #3160

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Conversation

kwapik
Copy link
Contributor

@kwapik kwapik commented Jan 23, 2024

Description of change

This ensures agent_group label is added to metrics sent to Aperture Cloud.

Resolves: #3085

Checklist
  • Tested in playground or other setup

Summary by CodeRabbit

  • New Features
    • Enhanced telemetry by including a new processor in the metrics pipeline.

@kwapik kwapik requested a review from a team as a code owner January 23, 2024 17:19
Copy link
Contributor

coderabbitai bot commented Jan 23, 2024

Walkthrough

The recent update includes the integration of a new constant, otelconsts.ProcessorAgentGroup, within the addMetricsSlowPipeline function. This suggests an enhancement to the observability aspect of the application, likely improving the monitoring capabilities for a specific group of metric processors.

Changes

File Path Change Summary
extensions/fluxninja/otel/provide.go Added otelconsts.ProcessorAgentGroup to Processors in addMetricsSlowPipeline.

Poem

In the code where metrics flow,
A new constant joins the show.
🐇 With a hop, skip, and a leap,
'Tis a change not just to keep.


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@kwapik kwapik enabled auto-merge (squash) January 23, 2024 17:20
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 4602e27 and fcdde1f.
Files selected for processing (1)
  • extensions/fluxninja/otel/provide.go (1 hunks)
Additional comments: 1
extensions/fluxninja/otel/provide.go (1)
  • 173-173: The addition of otelconsts.ProcessorAgentGroup to the Processors list in the addMetricsSlowPipeline function aligns with the PR's objective to append the agent_group label to metrics.

@kwapik kwapik merged commit 8bf3b05 into main Jan 23, 2024
17 of 19 checks passed
@kwapik kwapik deleted the kwapik/agent-group-processor branch January 23, 2024 17:43
hasit pushed a commit that referenced this pull request Jan 23, 2024
### Description of change
This ensures `agent_group` label is added to metrics sent to Aperture
Cloud.

Resolves: #3085

##### Checklist

- [x] Tested in playground or other setup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add agent_group label through OTEL pipeline so that it applies to all metrics
2 participants