Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add agent_group label through OTEL pipeline so that it applies to all metrics #3085

Closed
tanveergill opened this issue Dec 27, 2023 · 2 comments · Fixed by #3160
Closed

Add agent_group label through OTEL pipeline so that it applies to all metrics #3085

tanveergill opened this issue Dec 27, 2023 · 2 comments · Fixed by #3160
Assignees
@hdkshingala
Labels
Agent Telemetry

Comments

@tanveergill
Copy link
Contributor

No description provided.

@hdkshingala
Copy link
Contributor

@tanveergill Seems like we already add a processor to insert the agent_group attributes in logs and metrics - https://github.com/fluxninja/aperture/blob/main/cmd/aperture-agent/agent/provider.go#L30

Please let me know the metrics not having the agent_group label and I can check which pipeline is handling it

@tanveergill
Copy link
Contributor Author

@hdkshingala,

Just picked up a random metric. Did not see agent_group label on it. Also, noticed that we have been injecting these label manually on some metrics: https://github.com/fluxninja/aperture/blob/main/pkg/policies/flowcontrol/service/check/metrics.go#L81
Screenshot 2024-01-05 at 6 33 35 PM

@tanveergill tanveergill assigned hdkshingala and unassigned hasit Jan 11, 2024
@kwapik kwapik mentioned this issue Jan 23, 2024
Merged
1 task
kwapik added a commit that referenced this issue Jan 23, 2024
@kwapik
Add Agent Group processor to FN pipeline (#3160)
8bf3b05 
### Description of change
This ensures `agent_group` label is added to metrics sent to Aperture
Cloud.

Resolves: #3085

##### Checklist

- [x] Tested in playground or other setup
hasit pushed a commit that referenced this issue Jan 23, 2024
@kwapik @hasit
Add Agent Group processor to FN pipeline (#3160)
8792ee6 
### Description of change
This ensures `agent_group` label is added to metrics sent to Aperture
Cloud.

Resolves: #3085

##### Checklist

- [x] Tested in playground or other setup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hdkshingala hdkshingala

Labels
Agent Telemetry
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Agent Group processor to FN pipeline fluxninja/aperture
3 participants
@hasit @tanveergill @hdkshingala