Implement client for Deploy Tokens #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timofurrer
force-pushed
the
gitlab-deploy-token
branch
from
b86e21e
to
7da630e
Compare
timofurrer
added a commit
to timofurrer/flux2
that referenced
this pull request
Mar 3, 2023
This change set implements support for the `--deploy-token-auth` option in the `flux bootstrap gitlab` command. That option will reconcile a GitLab Project Deploy Token to use for the authentication of the GitLab git repository. A GitLab Project Deploy Token can be used the same way as a Personal Access Token which is already supported via `--token-auth`. The difference with the GitLab Project Deploy Token is that the token is managed (created, updated, deleted) by Flux and not provided by the user. This change is transparent to the source-controller. A prerequisite for this change is the `fluxcd/go-git-providers` change here: * fluxcd/go-git-providers#191 See related discussion here: fluxcd#3595 GitLab Issue here: https://gitlab.com/gitlab-org/gitlab/-/issues/392605
timofurrer
added a commit
to timofurrer/flux2
that referenced
this pull request
Mar 3, 2023
This change set implements support for the `--deploy-token-auth` option in the `flux bootstrap gitlab` command. That option will reconcile a GitLab Project Deploy Token to use for the authentication of the GitLab git repository. A GitLab Project Deploy Token can be used the same way as a Personal Access Token which is already supported via `--token-auth`. The difference with the GitLab Project Deploy Token is that the token is managed (created, updated, deleted) by Flux and not provided by the user. This change is transparent to the source-controller. A prerequisite for this change is the `fluxcd/go-git-providers` change here: * fluxcd/go-git-providers#191 See related discussion here: fluxcd#3595 GitLab Issue here: https://gitlab.com/gitlab-org/gitlab/-/issues/392605 Signed-off-by: Timo Furrer <[email protected]>
timofurrer
added a commit
to timofurrer/flux2
that referenced
this pull request
Mar 6, 2023
This change set implements support for the `--deploy-token-auth` option in the `flux bootstrap gitlab` command. That option will reconcile a GitLab Project Deploy Token to use for the authentication of the GitLab git repository. A GitLab Project Deploy Token can be used the same way as a Personal Access Token which is already supported via `--token-auth`. The difference with the GitLab Project Deploy Token is that the token is managed (created, updated, deleted) by Flux and not provided by the user. This change is transparent to the source-controller. A prerequisite for this change is the `fluxcd/go-git-providers` change here: * fluxcd/go-git-providers#191 See related discussion here: fluxcd#3595 GitLab Issue here: https://gitlab.com/gitlab-org/gitlab/-/issues/392605 Signed-off-by: Timo Furrer <[email protected]>
makkes
added
enhancement
makkes
reviewed
Mar 6, 2023
timofurrer
added a commit
to timofurrer/flux2
that referenced
this pull request
Mar 6, 2023
This change set implements support for the `--deploy-token-auth` option in the `flux bootstrap gitlab` command. That option will reconcile a GitLab Project Deploy Token to use for the authentication of the GitLab git repository. A GitLab Project Deploy Token can be used the same way as a Personal Access Token which is already supported via `--token-auth`. The difference with the GitLab Project Deploy Token is that the token is managed (created, updated, deleted) by Flux and not provided by the user. This change is transparent to the source-controller. A prerequisite for this change is the `fluxcd/go-git-providers` change here: * fluxcd/go-git-providers#191 See related discussion here: fluxcd#3595 GitLab Issue here: https://gitlab.com/gitlab-org/gitlab/-/issues/392605 Signed-off-by: Timo Furrer <[email protected]>
timofurrer
force-pushed
the
gitlab-deploy-token
branch
2 times, most recently
from
f46145f
to
a17cf9d
Compare
timofurrer
added a commit
to timofurrer/go-git-providers
that referenced
this pull request
Mar 7, 2023
This `go-gitlab` upgrade contains xanzy/go-gitlab#1662 which is a prerequisite for my other open PR at fluxcd#191. Signed-off-by: Timo Furrer <[email protected]>
timofurrer
added a commit
to timofurrer/go-git-providers
that referenced
this pull request
Mar 9, 2023
This `go-gitlab` upgrade contains xanzy/go-gitlab#1662 which is a prerequisite for my other open PR at fluxcd#191. Signed-off-by: Timo Furrer <[email protected]>
timofurrer
added a commit
to timofurrer/go-git-providers
that referenced
this pull request
Mar 9, 2023
This `go-gitlab` upgrade contains xanzy/go-gitlab#1662 which is a prerequisite for my other open PR at fluxcd#191. Signed-off-by: Timo Furrer <[email protected]>
makkes
reviewed
Mar 13, 2023
makkes
reviewed
Mar 13, 2023
timofurrer
force-pushed
the
gitlab-deploy-token
branch
2 times, most recently
from
a56167d
to
ecf5fd0
Compare
makkes
reviewed
Mar 13, 2023
timofurrer
force-pushed
the
gitlab-deploy-token
branch
from
59bb038
to
cef51e9
Compare
This change set implements a `DeployTokenClient` and the associated resource to support GitLab Deploy Tokens in the Flux CLI. See related discussion here: fluxcd/flux2#3595 GitLab Issue here: https://gitlab.com/gitlab-org/gitlab/-/issues/392605 Prerequisite for this to merge is a new release from `go-gitlab` and update in this package which includes: - xanzy/go-gitlab#1662 Signed-off-by: Timo Furrer <[email protected]>
Signed-off-by: Timo Furrer <[email protected]>
Signed-off-by: Max Jonas Werner <[email protected]>
makkes
force-pushed
the
gitlab-deploy-token
branch
from
cef51e9
to
b79b5d5
Compare
makkes
approved these changes
Mar 14, 2023
timofurrer
added a commit
to timofurrer/flux2
that referenced
this pull request
Mar 14, 2023
This change set implements support for the `--deploy-token-auth` option in the `flux bootstrap gitlab` command. That option will reconcile a GitLab Project Deploy Token to use for the authentication of the GitLab git repository. A GitLab Project Deploy Token can be used the same way as a Personal Access Token which is already supported via `--token-auth`. The difference with the GitLab Project Deploy Token is that the token is managed (created, updated, deleted) by Flux and not provided by the user. This change is transparent to the source-controller. A prerequisite for this change is the `fluxcd/go-git-providers` change here: * fluxcd/go-git-providers#191 See related discussion here: fluxcd#3595 GitLab Issue here: https://gitlab.com/gitlab-org/gitlab/-/issues/392605 Signed-off-by: Timo Furrer <[email protected]>
timofurrer
added a commit
to timofurrer/flux2
that referenced
this pull request
Mar 14, 2023
This change set implements support for the `--deploy-token-auth` option in the `flux bootstrap gitlab` command. That option will reconcile a GitLab Project Deploy Token to use for the authentication of the GitLab git repository. A GitLab Project Deploy Token can be used the same way as a Personal Access Token which is already supported via `--token-auth`. The difference with the GitLab Project Deploy Token is that the token is managed (created, updated, deleted) by Flux and not provided by the user. This change is transparent to the source-controller. A prerequisite for this change is the `fluxcd/go-git-providers` change here: * fluxcd/go-git-providers#191 See related discussion here: fluxcd#3595 GitLab Issue here: https://gitlab.com/gitlab-org/gitlab/-/issues/392605 Signed-off-by: Timo Furrer <[email protected]>
timofurrer
added a commit
to timofurrer/flux2
that referenced
this pull request
Mar 15, 2023
This change set implements support for the `--deploy-token-auth` option in the `flux bootstrap gitlab` command. That option will reconcile a GitLab Project Deploy Token to use for the authentication of the GitLab git repository. A GitLab Project Deploy Token can be used the same way as a Personal Access Token which is already supported via `--token-auth`. The difference with the GitLab Project Deploy Token is that the token is managed (created, updated, deleted) by Flux and not provided by the user. This change is transparent to the source-controller. A prerequisite for this change is the `fluxcd/go-git-providers` change here: * fluxcd/go-git-providers#191 See related discussion here: fluxcd#3595 GitLab Issue here: https://gitlab.com/gitlab-org/gitlab/-/issues/392605 Signed-off-by: Timo Furrer <[email protected]>
timofurrer
added a commit
to timofurrer/flux2
that referenced
this pull request
Mar 20, 2023
This change set implements support for the `--deploy-token-auth` option in the `flux bootstrap gitlab` command. That option will reconcile a GitLab Project Deploy Token to use for the authentication of the GitLab git repository. A GitLab Project Deploy Token can be used the same way as a Personal Access Token which is already supported via `--token-auth`. The difference with the GitLab Project Deploy Token is that the token is managed (created, updated, deleted) by Flux and not provided by the user. This change is transparent to the source-controller. A prerequisite for this change is the `fluxcd/go-git-providers` change here: * fluxcd/go-git-providers#191 See related discussion here: fluxcd#3595 GitLab Issue here: https://gitlab.com/gitlab-org/gitlab/-/issues/392605 Signed-off-by: Timo Furrer <[email protected]>
timofurrer
added a commit
to timofurrer/flux2
that referenced
this pull request
Mar 20, 2023
This change set implements support for the `--deploy-token-auth` option in the `flux bootstrap gitlab` command. That option will reconcile a GitLab Project Deploy Token to use for the authentication of the GitLab git repository. A GitLab Project Deploy Token can be used the same way as a Personal Access Token which is already supported via `--token-auth`. The difference with the GitLab Project Deploy Token is that the token is managed (created, updated, deleted) by Flux and not provided by the user. This change is transparent to the source-controller. A prerequisite for this change is the `fluxcd/go-git-providers` change here: * fluxcd/go-git-providers#191 See related discussion here: fluxcd#3595 GitLab Issue here: https://gitlab.com/gitlab-org/gitlab/-/issues/392605 Signed-off-by: Timo Furrer <[email protected]>
timofurrer
added a commit
to timofurrer/flux2
that referenced
this pull request
Mar 20, 2023
This change set implements support for the `--deploy-token-auth` option in the `flux bootstrap gitlab` command. That option will reconcile a GitLab Project Deploy Token to use for the authentication of the GitLab git repository. A GitLab Project Deploy Token can be used the same way as a Personal Access Token which is already supported via `--token-auth`. The difference with the GitLab Project Deploy Token is that the token is managed (created, updated, deleted) by Flux and not provided by the user. This change is transparent to the source-controller. A prerequisite for this change is the `fluxcd/go-git-providers` change here: * fluxcd/go-git-providers#191 See related discussion here: fluxcd#3595 GitLab Issue here: https://gitlab.com/gitlab-org/gitlab/-/issues/392605 Signed-off-by: Timo Furrer <[email protected]>
timofurrer
added a commit
to timofurrer/flux2
that referenced
this pull request
Mar 20, 2023
This change set implements support for the `--deploy-token-auth` option in the `flux bootstrap gitlab` command. That option will reconcile a GitLab Project Deploy Token to use for the authentication of the GitLab git repository. A GitLab Project Deploy Token can be used the same way as a Personal Access Token which is already supported via `--token-auth`. The difference with the GitLab Project Deploy Token is that the token is managed (created, updated, deleted) by Flux and not provided by the user. This change is transparent to the source-controller. A prerequisite for this change is the `fluxcd/go-git-providers` change here: * fluxcd/go-git-providers#191 See related discussion here: fluxcd#3595 GitLab Issue here: https://gitlab.com/gitlab-org/gitlab/-/issues/392605 Signed-off-by: Timo Furrer <[email protected]>
hiddeco
pushed a commit
to timofurrer/flux2
that referenced
this pull request
Mar 21, 2023
This change set implements support for the `--deploy-token-auth` option in the `flux bootstrap gitlab` command. That option will reconcile a GitLab Project Deploy Token to use for the authentication of the GitLab git repository. A GitLab Project Deploy Token can be used the same way as a Personal Access Token which is already supported via `--token-auth`. The difference with the GitLab Project Deploy Token is that the token is managed (created, updated, deleted) by Flux and not provided by the user. This change is transparent to the source-controller. A prerequisite for this change is the `fluxcd/go-git-providers` change here: * fluxcd/go-git-providers#191 See related discussion here: fluxcd#3595 GitLab Issue here: https://gitlab.com/gitlab-org/gitlab/-/issues/392605 Signed-off-by: Timo Furrer <[email protected]>
souleb
pushed a commit
to souleb/flux2
that referenced
this pull request
Jul 10, 2023
This change set implements support for the `--deploy-token-auth` option in the `flux bootstrap gitlab` command. That option will reconcile a GitLab Project Deploy Token to use for the authentication of the GitLab git repository. A GitLab Project Deploy Token can be used the same way as a Personal Access Token which is already supported via `--token-auth`. The difference with the GitLab Project Deploy Token is that the token is managed (created, updated, deleted) by Flux and not provided by the user. This change is transparent to the source-controller. A prerequisite for this change is the `fluxcd/go-git-providers` change here: * fluxcd/go-git-providers#191 See related discussion here: fluxcd#3595 GitLab Issue here: https://gitlab.com/gitlab-org/gitlab/-/issues/392605 Signed-off-by: Timo Furrer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change set implements a
DeployTokenClientand the associated resource to support GitLab Deploy Tokens in the Flux CLI.See related discussion here: fluxcd/flux2#3595
GitLab Issue here: https://gitlab.com/gitlab-org/gitlab/-/issues/392605
Prerequisite for this to merge is a new release from
go-gitlaband update in this package which includes:Test results