Implement --deploy-token-auth in GitLab bootstrapping
#3654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timofurrer
force-pushed
the
gitlab-deploy-token-auth
branch
3 times, most recently
from
6367bf7
to
fc38fb8
Compare
timofurrer
force-pushed
the
gitlab-deploy-token-auth
branch
2 times, most recently
from
a3d1173
to
a955409
Compare
|
@makkes I think that we can proceed here as well now that fluxcd/go-git-providers#191 has been merged and released. WDYT? |
timofurrer
force-pushed
the
gitlab-deploy-token-auth
branch
from
a955409
to
1499171
Compare
makkes
reviewed
Mar 20, 2023
timofurrer
force-pushed
the
gitlab-deploy-token-auth
branch
4 times, most recently
from
cf1d768
to
3628c11
Compare
makkes
approved these changes
Mar 20, 2023
|
This is on hold until we are done with the last cycle of bug fixes to the |
makkes
added
enhancement
|
@hiddeco where can I learn more about the timeline of this release, if there is any? When could I expect to have it in ? |
|
@timofurrer I expected this to be sometime next week. We need to wrap up some other bigger changes like promoting the |
|
@hiddeco sounds great! Thanks for the info. |
Signed-off-by: Timo Furrer <[email protected]>
This change set implements support for the `--deploy-token-auth` option in the `flux bootstrap gitlab` command. That option will reconcile a GitLab Project Deploy Token to use for the authentication of the GitLab git repository. A GitLab Project Deploy Token can be used the same way as a Personal Access Token which is already supported via `--token-auth`. The difference with the GitLab Project Deploy Token is that the token is managed (created, updated, deleted) by Flux and not provided by the user. This change is transparent to the source-controller. A prerequisite for this change is the `fluxcd/go-git-providers` change here: * fluxcd/go-git-providers#191 See related discussion here: fluxcd#3595 GitLab Issue here: https://gitlab.com/gitlab-org/gitlab/-/issues/392605 Signed-off-by: Timo Furrer <[email protected]>
hiddeco
force-pushed
the
gitlab-deploy-token-auth
branch
from
3628c11
to
2e1721c
Compare
makkes
approved these changes
Mar 23, 2023
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change set implements support for the
--deploy-token-authoption in theflux bootstrap gitlabcommand.That option will reconcile a GitLab Project Deploy Token to use for the authentication of the GitLab git repository.
A GitLab Project Deploy Token can be used the same way as a Personal Access Token which is already supported via
--token-auth. The difference with the GitLab Project Deploy Token is that the token is managed (created, updated, deleted) by Flux and not provided by the user.This change is transparent to the source-controller.
A prerequisite for this change is the
fluxcd/go-git-providerschange here:See related discussion here: #3595
GitLab Issue here: https://gitlab.com/gitlab-org/gitlab/-/issues/392605