Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated io/ioutil usage #1687

Merged
merged 1 commit into from
Aug 4, 2021
Merged

Remove deprecated io/ioutil usage #1687

merged 1 commit into from
Aug 4, 2021

Conversation

allenporter
Copy link
Contributor

Changes:

hiddeco
hiddeco approved these changes Aug 4, 2021
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are on a strike @allenporter! Thank you very much 🥇

@stefanprodan
Copy link
Member

Can you please move os.Setenv from init to TestMain please?

@hiddeco
Copy link
Member

hiddeco commented Aug 4, 2021

Should be done in a separate PR as this series of PRs is solely focusing on removing the deprecated package.

@hiddeco hiddeco merged commit 78f4dfa into fluxcd:main Aug 4, 2021
@allenporter allenporter deleted the flux-cmd-ioutil branch August 5, 2021 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@allenporter @stefanprodan @hiddeco