Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated io/ioutil from projects #1658

Closed
hiddeco opened this issue Jul 29, 2021 · 6 comments · Fixed by #2113
Closed

Remove deprecated io/ioutil from projects #1658

hiddeco opened this issue Jul 29, 2021 · 6 comments · Fixed by #2113
Labels
good first issue Good for newcomers

Comments

@hiddeco
Copy link
Member

hiddeco commented Jul 29, 2021

All of our projects make use of Go 1.16, and io/ioutil has been deprecated since this version: https://golang.org/doc/go1.16#ioutil

We should remove all traces in our projects and replace them with the suggestions from the deprecation notice.

https://github.com/search?q=ioutil+org%3Afluxcd&type=code

@krishnaindani
Copy link

Are there still changes to be made with this issue, could I work on this?

allenporter added a commit to allenporter/flux2 that referenced this issue Aug 4, 2021
allenporter added a commit to allenporter/flux2 that referenced this issue Aug 4, 2021
@josephwoodward
Copy link

Judging by the merged pull requests above, this issue is no longer relevant and can be closed?

@allenporter
Copy link
Contributor

There are still many to cleanup: https://github.com/search?q=ioutil+org%3Afluxcd&type=code

@dholbach
Copy link
Member

Everything else is flux, flux-recv and helm-operator from what I can see.

@dholbach
Copy link
Member

source-watcher and website should be fixed separately - anyone interested in picking this up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants