Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add release notes for flux-security v0.12.0 #190

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

grondo
Copy link
Contributor

@grondo grondo commented Nov 3, 2024

This PR adds release notes for flux-security v0.12.0, including PRs #188 and #189 assume they'll be merged.

Copy link

codecov bot commented Nov 3, 2024

Codecov Report

Attention: Patch coverage is 71.87500% with 9 lines in your changes missing coverage. Please review.

Project coverage is 84.81%. Comparing base (44adb43) to head (a366457).
Report is 24 commits behind head on master.

Files with missing lines Patch % Lines
src/imp/run.c 71.87% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #190      +/-   ##
==========================================
- Coverage   85.88%   84.81%   -1.07%     
==========================================
  Files          36       37       +1     
  Lines        4918     4881      -37     
==========================================
- Hits         4224     4140      -84     
- Misses        694      741      +47     
Files with missing lines Coverage Δ
src/imp/pidinfo.c 76.84% <ø> (-7.08%) ⬇️
src/imp/run.c 83.57% <71.87%> (-2.61%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Member

@garlick garlick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Problem: There are no release notes for flux-security v0.12.

Add them.
@grondo
Copy link
Contributor Author

grondo commented Nov 4, 2024

Rebased and added MWP. Thanks!

@mergify mergify bot merged commit 1c6a2c1 into flux-framework:master Nov 4, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants