remove flux-imp kill command
#189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garlick
previously approved these changes
Nov 4, 2024
grondo
dismissed
garlick’s stale review
The merge-base changed after approval.
Problem: The `flux-imp kill` subcommand is no longer necessary, since both IMP exec and run subcommands now have a privleged IMP parent process via which signals may be forwarded. Remove the `kill` subcommand and associated tests.
Problem: The `struct pidinfo` abstraction was only required by the IMP kill subcommand, which has been removed. Remove pidinfo related code and tests.
Problem: The `flux-imp kill` command is mentioned in flux-imp(8), but it has been removed. Remove it from the man page.
grondo
force-pushed
the
excise-imp-kill
branch
from
c2311ba to
c93b143
Compare
|
Yes! Thanks, setting MWP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #188 is merged, the
flux-imp killcommand is no longer necessary.This PR removes the command along with associated code and tests.
(based on #188 for now)