fix macos portability issues (sixth batch) #6508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: libev asserts in ev_epoll.c on macos.
Assertion failed: (("libev: I/O watcher with invalid fd found in epoll_ctl", errno != EBADF && errno != ELOOP && errno != EINVAL)), function epoll_modify, file ev_epoll.c, line 134.
The fact that libev is using epoll, which is not native to macos,
indicates that its configure logic is getting confused by the presence
of the epoll-shim (required for the flux_t handle implementation).
Get around this by adding a configure option --with-external-libev so
we can use the homebrew libev, which is properly configured to use kqueue
instead of epoll.
Fixes flux-framework#6485
Problem: install-deps-macos.sh doesn't install the homebrew libev, and configure-macos.sh doesn't configure --with-external-libev. Update macos scripts.
Problem: some tests fail on macos because dlerror(3) produces different output, e.g. "not a file" vs "Is a directory". Adjust libtap like() regex to relax match requirements.
Problem: some tests fail on macos because strsignal(3) produces
different output, e.g.
got: 'task(s) Segmentation fault: 11'
expected: 'task(s) Segmentation fault'
Use libtap like() instead of is() to relax match requirements.
This reverts commit fd4dd44.
Problem: a subset of flux works on macos so far, but because we do not run 'make check' in CI, regressions are likely. Add a script that runs specific tests known to work on macos. Call it from the macos builder in CI.
|
Thanks! I'll set MWP. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6508 +/- ##
==========================================
- Coverage 83.63% 83.61% -0.02%
==========================================
Files 522 522
Lines 87680 87680
==========================================
- Hits 73330 73315 -15
- Misses 14350 14365 +15
|
chu11
pushed a commit
to chu11/flux-core
that referenced
this pull request
Dec 17, 2024
fix macos portability issues (sixth batch)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few more issues, plus adds the capability to build flux-core with an external libev for #6485. Finally, run the working unit tests under macos so we don't end up with regressions there.
This is built on top of #6494 because localizing the libev code mad this PR easier.