Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macos: add configure --with-external-libev #6485

Closed
garlick opened this issue Dec 6, 2024 · 1 comment
Closed

macos: add configure --with-external-libev #6485

garlick opened this issue Dec 6, 2024 · 1 comment

Comments

@garlick
Copy link
Member

garlick commented Dec 6, 2024

Problem: make check fails on macos in early unit tests.

Just the first couple of issues that may indicate actual problems as opposed to non-portable tests:

  • libflux/test_future.t fails on

    Assertion failed: (("libev: I/O watcher with invalid fd found in epoll_ctl", errno != EBADF && errno != ELOOP && errno != EINVAL)), function epoll_modify, file ev_epoll.c, line 134.

  • libflux/test_reactor.t hangs in test_child(). Possibly child watchers don't work, which is rather critical
@garlick
Copy link
Member Author

garlick commented Dec 14, 2024

Both of these problems seem to stem from libev using the epoll-shim, when it actually has support for kqueue. At least building flux-core against the brew version of libev appears to get around them.

If we do that on macos then we can also revert fd4dd44

I'll retitle this to reflect the need for configure-fu for external libev

@garlick garlick changed the title macos: make check fails macos: add configure --with-external-libev Dec 14, 2024
garlick added a commit to garlick/flux-core that referenced this issue Dec 14, 2024
Problem: libev asserts in ev_epoll.c on macos.

Assertion failed: (("libev: I/O watcher with invalid fd found in epoll_ctl", errno != EBADF && errno != ELOOP && errno != EINVAL)), function epoll_modify, file ev_epoll.c, line 134.

The fact that libev is using epoll, which is not native to macos,
indicates that its configure logic is getting confused by the presence
of the epoll-shim (required for the flux_t handle implementation).

Get around this by adding a configure option --with-external-libev so
we can use the homebrew libev, which is properly configured to use kqueue
instead of epoll.

Fixes flux-framework#6485
garlick added a commit to garlick/flux-core that referenced this issue Dec 14, 2024
Problem: libev asserts in ev_epoll.c on macos.

Assertion failed: (("libev: I/O watcher with invalid fd found in epoll_ctl", errno != EBADF && errno != ELOOP && errno != EINVAL)), function epoll_modify, file ev_epoll.c, line 134.

The fact that libev is using epoll, which is not native to macos,
indicates that its configure logic is getting confused by the presence
of the epoll-shim (required for the flux_t handle implementation).

Get around this by adding a configure option --with-external-libev so
we can use the homebrew libev, which is properly configured to use kqueue
instead of epoll.

Fixes flux-framework#6485
@mergify mergify bot closed this as completed in c4eae0b Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant