Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testsuite: fix fileref unit test failure on tmpfs #5643

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

garlick
Copy link
Member

@garlick garlick commented Dec 28, 2023

Problem: the fileref unit test fails on tmpfs in debian 11, kernel 6.1.0-rpi7-rpi-2712.

Although tmpfs supports sparse files, in some cases the test's efforts to create sparse test files are unsuccessful.

Skip tests when the test file must be sparse and is not.

Fixes #5642

Problem: the fileref unit test fails on tmpfs in debian 11,
kernel 6.1.0-rpi7-rpi-2712.

Although tmpfs supports sparse files, in some cases the test's efforts
to create sparse test files are unsuccessful.

Skip tests when the test file must be sparse and is not.

Fixes flux-framework#5642
Copy link
Contributor

@grondo grondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Merging #5643 (d2b418b) into master (beeb4ef) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5643   +/-   ##
=======================================
  Coverage   83.46%   83.46%           
=======================================
  Files         487      487           
  Lines       82931    82931           
=======================================
+ Hits        69216    69220    +4     
+ Misses      13715    13711    -4     

see 8 files with indirect coverage changes

@mergify mergify bot merged commit d54e364 into flux-framework:master Dec 28, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

not ok 3 - fileref_create chunksize=0 'a-aa' works (2 sha1 blobrefs)
2 participants