Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not ok 3 - fileref_create chunksize=0 'a-aa' works (2 sha1 blobrefs) #5642

Closed
garlick opened this issue Dec 28, 2023 · 0 comments · Fixed by #5643
Closed

not ok 3 - fileref_create chunksize=0 'a-aa' works (2 sha1 blobrefs) #5642

garlick opened this issue Dec 28, 2023 · 0 comments · Fixed by #5643
Assignees

Comments

@garlick
Copy link
Member

garlick commented Dec 28, 2023

Problem: some sparse file fileref unit tests fail on Debian 12 tmpfs:

ok 1 - fileref_create chunksize=0 'aaaa' works (1 sha1 blobrefs)
ok 2 - fileref_create chunksize=0 '-aaa' works (1 sha1 blobrefs)
# fileref.blobvec has incorrect length (expected 2 got 1)
not ok 3 - fileref_create chunksize=0 'a-aa' works (2 sha1 blobrefs)
#   Failed test 'fileref_create chunksize=0 'a-aa' works (2 sha1 blobrefs)'
#   at test/fileref.c line 489.
ok 4 - fileref_create chunksize=0 'aaa-' works (1 sha1 blobrefs)
ok 5 - fileref_create chunksize=0 '----' works (0 sha1 blobrefs)
# fileref.blobvec has incorrect length (expected 3 got 1)
not ok 6 - fileref_create chunksize=0 'ac-e--f-' works (3 sha1 blobrefs)
#   Failed test 'fileref_create chunksize=0 'ac-e--f-' works (3 sha1 blobrefs)'
#   at test/fileref.c line 489.
ok 7 - fileref_create chunksize=5500 'aaaa' works (3 sha1 blobrefs)
ok 8 - fileref_create chunksize=8192 'aaaa' works (2 sha1 blobrefs)
ok 9 - fileref_create chunksize=16384 'aaaa' works (1 sha1 blobrefs)
# fileref.blobvec has incorrect length (expected 2 got 4)
not ok 10 - fileref_create chunksize=4096 'a--a' works (2 sha1 blobrefs)
#   Failed test 'fileref_create chunksize=4096 'a--a' works (2 sha1 blobrefs)'
#   at test/fileref.c line 489.
# fileref.blobvec has incorrect length (expected 2 got 4)
not ok 11 - fileref_create chunksize=5000 'a--a' works (2 sha1 blobrefs)
#   Failed test 'fileref_create chunksize=5000 'a--a' works (2 sha1 blobrefs)'
#   at test/fileref.c line 489.
# fileref.blobvec has incorrect length (expected 4 got 6)
not ok 12 - fileref_create chunksize=3000 'a--a' works (4 sha256 blobrefs)
#   Failed test 'fileref_create chunksize=3000 'a--a' works (4 sha256 blobrefs)'
#   at test/fileref.c line 489.

These tests are skipped if the file system does not support sparse files, but that check passes in this case.

I suppose the decision of whether to preserve the sparseness is really up to the file system so the test is inherently fragile.

@garlick garlick self-assigned this Dec 28, 2023
garlick added a commit to garlick/flux-core that referenced this issue Dec 28, 2023
Problem: the fileref unit test fails on tmpfs in debian 11,
kernel 6.1.0-rpi7-rpi-2712.

Although tmpfs supports sparse files, in some cases the test's efforts
to create sparse test files are unsuccessful.

Skip tests when the test file must be sparse and is not.

Fixes flux-framework#5642
@mergify mergify bot closed this as completed in #5643 Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant