broker: log content store errors to LOG_CRIT #4526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chu11
force-pushed
the
issue4472_broker_log_crit_content_store_failure
branch
from
764f3c8 to
fb747e5
Compare
Codecov Report
@@ Coverage Diff @@
## master #4526 +/- ##
==========================================
- Coverage 83.38% 83.36% -0.02%
==========================================
Files 403 402 -1
Lines 67736 67664 -72
==========================================
- Hits 56480 56409 -71
+ Misses 11256 11255 -1
|
garlick
reviewed
Aug 26, 2022
src/broker/content-cache.c
Outdated
| @@ -505,7 +505,7 @@ static void cache_store_continuation (flux_future_t *f, void *arg) | |||
| flux_log (cache->h, LOG_DEBUG, "content store: %s", | |||
| "backing store service unavailable"); | |||
| else | |||
| flux_log_error (cache->h, "content store"); | |||
| flux_log (cache->h, LOG_CRIT, "content store"); | |||
There was a problem hiding this comment.
Should be
flux_log (cache->h, LOG_CRIT, "content store: %s", strerror (errno));There was a problem hiding this comment.
oh yeah, no strerror output when you take out the error ... my bad, sloppy :P
chu11
force-pushed
the
issue4472_broker_log_crit_content_store_failure
branch
from
fb747e5 to
b27c5ea
Compare
|
re-pushed, fixing up the 1 line ... in my 1 line patch :P |
Problem: In the event of content store errors, such as ENOSPC if the disk is full, error messages are logged to LOG_ERR. This does not properly signify the severity of the error, as something like ENOSPC would mean no data is being backed up to disk. Solution: Log to LOG_CRIT, to signify the importance of this issue and the need for it to be resolved.
jameshcorbett
force-pushed
the
issue4472_broker_log_crit_content_store_failure
branch
from
b27c5ea to
e6c152b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: In the event of content store errors, such as ENOSPC
if the disk is full, error messages are logged to LOG_ERR. This
does not properly signify the severity of the error, as something
like ENOSPC would mean no data is being backed up to disk.
Solution: Log to LOG_CRIT, to signify the importance of this
issue and the need for it to be resolved.