Skip to content

Commit

Permalink
broker: log content store errors to LOG_CRIT
Browse files Browse the repository at this point in the history
Problem: In the event of content store errors, such as ENOSPC
if the disk is full, error messages are logged to LOG_ERR.  This
does not properly signify the severity of the error, as something
like ENOSPC would mean no data is being backed up to disk.

Solution: Log to LOG_CRIT, to signify the importance of this
issue and the need for it to be resolved.
  • Loading branch information
chu11 committed Aug 26, 2022
1 parent ba4c510 commit b27c5ea
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/broker/content-cache.c
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,8 @@ static void cache_store_continuation (flux_future_t *f, void *arg)
flux_log (cache->h, LOG_DEBUG, "content store: %s",
"backing store service unavailable");
else
flux_log_error (cache->h, "content store");
flux_log (cache->h, LOG_CRIT, "content store: %s",
strerror (errno));
goto error;
}
if (hash_size != content_hash_size
Expand Down

0 comments on commit b27c5ea

Please sign in to comment.