libflux: drop flux_sec_t class from public API

[garlick]

As suggested in #1843, the flux_sec_t code is only used by the broker and flux-keygen and doesn't have an out of tree use case that I can think of. It's also old code in need of a makeover.

Hence, move it to libutil/zecurity.[ch] and re-namespace from flux_sec_* to zsecurity_*

[SteVwonder]

sec.py should be removed from fluxpy_PYTHON in src/bindings/python/flux/Makefile.am.

In t/valgrind/valgrind.supp there is a reference to fun:flux_sec_comms_init that should change to fun:zsecurity_comms_init.

Otherwise, LGMT! Thanks @garlick!

[garlick]

Thanks @SteVwonder! That was timely as I've got to put my laptop away and hit the road.

I had misspelled "python" in one of those commits, so I just went ahead and forced a push with your suggested changes.

[garlick]

Crud, still looks like it's failing something in python land. I went ahead and rebased.

[SteVwonder]

Looks like pylint is unhappy because flux/__init__.py still lists sec under __all__: https://github.com/flux-framework/flux-core/blob/master/src/bindings/python/flux/__init__.py#L15 Removing it from the list should fix that. The binding tests still work because none of them leverage __all__ like via a wildcard import (from flux import *), which is bad form anyway.

Pylint error message:

************* Module flux
E: 15,11: Undefined variable name 'sec' in __all__ (undefined-all-variable)

I'm not sure why the first builder (with no configure flags) failed. All I found was:

       t2202-job-manager.t:  PASS: N=30  PASS=30  FAIL=0 SKIP=0 XPASS=0 XFAIL=0
ERROR: t2202-job-manager.t - exited with status 137 (terminated by signal 9?)

Maybe just a transient error? Restarting that builder just to see what happens.

[codecov-io]

Codecov Report

Merging #1846 into master will decrease coverage by 0.03%.
The diff coverage is 71.64%.

@@            Coverage Diff             @@
##           master    #1846      +/-   ##
==========================================
- Coverage   79.91%   79.87%   -0.04%     
==========================================
  Files         196      196              
  Lines       35267    35267              
==========================================
- Hits        28185    28171      -14     
- Misses       7082     7096      +14

Impacted Files	Coverage Δ
src/broker/broker.c	77.59% <37.5%> (ø)	⬆️
src/cmd/flux-keygen.c	54.83% <55.55%> (ø)	⬆️
src/broker/overlay.c	84.58% <57.14%> (ø)	⬆️
src/common/libutil/zsecurity.c	76.47% <83.72%> (ø)
src/common/libflux/response.c	79.62% <0%> (-1.24%)	⬇️
src/modules/connector-local/local.c	73.77% <0%> (-1.04%)	⬇️
src/broker/modservice.c	78.84% <0%> (-0.97%)	⬇️
src/common/libflux/message.c	81.15% <0%> (-0.49%)	⬇️

[garlick]

Looks like that restarted builder must've completed OK.

Thanks for the __init.py__ hint. Just pushed that and it seems like it worked.

[garlick]

This might be OK to merge despite the so-so coverage, since it's for the most part a straightforward move, coverage problems are pre-existing, and code needs to be reworked at some point.

[SteVwonder]

Yeah. I'm happy to merge as is. I'll wait for one other person to weigh in though (@chu11 or @grondo?).

[grondo]

Yeah, seems fine to me too

[grondo]

Merging so we can move other PRs along

[garlick]

Thanks!